Skip to content

Commit 3cd5bc3

Browse files
implemented review changes
1 parent 84924ac commit 3cd5bc3

File tree

3 files changed

+6
-10
lines changed

3 files changed

+6
-10
lines changed

x-pack/test/functional/apps/reporting_management/report_delete_pagination.ts

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {
2121
await security.testUser.setRoles(['global_discover_read', 'reporting_user']);
2222
await esArchiver.load('empty_kibana');
2323
await esArchiver.load('reporting/archived_reports');
24-
await pageObjects.common.navigateToActualUrl('kibana', '/management/kibana/reporting');
24+
await pageObjects.common.navigateToApp('reporting');
2525
await testSubjects.existOrFail('reportJobListing', { timeout: 200000 });
2626
});
2727

@@ -31,9 +31,8 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {
3131
await security.testUser.restoreDefaults();
3232
});
3333

34-
it('Confirm report deletion works', async () => {
34+
it('Confirm single report deletion works', async () => {
3535
log.debug('Checking for reports.');
36-
3736
await retry.try(async () => {
3837
await testSubjects.click('checkboxSelectRow-k9a9xlwl0gpe1457b10rraq3');
3938
});

x-pack/test/functional/config.js

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -197,6 +197,10 @@ export default async function({ readConfigFile }) {
197197
pathname: '/app/kibana/',
198198
hash: '/management/elasticsearch/transform',
199199
},
200+
reporting: {
201+
pathname: '/app/kibana/',
202+
hash: '/management/kibana/reporting',
203+
},
200204
},
201205

202206
// choose where esArchiver should load archives from

x-pack/test/functional/page_objects/reporting_page.js

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -169,13 +169,6 @@ export function ReportingPageProvider({ getService, getPageObjects }) {
169169
const toTime = 'Sep 23, 1999 @ 18:31:44.000';
170170
await PageObjects.timePicker.setAbsoluteRange(fromTime, toTime);
171171
}
172-
173-
async canReportBeCreated() {
174-
await this.clickGenerateReportButton();
175-
const success = await this.checkForReportingToasts();
176-
return success;
177-
}
178172
}
179-
180173
return new ReportingPage();
181174
}

0 commit comments

Comments
 (0)