Improve cypress tests

Author: cnasikas

x-pack/plugins/security_solution/cypress/integration/timeline_local_storage.spec.ts

@@ -26,21 +26,21 @@ describe('persistent timeline', () => {
   });
 
   it('persist the deletion of a column', () => {
-    const numberOfTimelineColumns = 9;
+    cy.get(DRAGGABLE_HEADER).then((header) => {
+      const currentNumberOfTimelineColumns = header.length;
+      const expectedNumberOfTimelineColumns = currentNumberOfTimelineColumns - 1;
 
-    cy.get(DRAGGABLE_HEADER)
-      .eq(TABLE_COLUMN_EVENTS_MESSAGE)
-      .invoke('text')
-      .should('equal', 'message');
+      cy.wrap(header).eq(TABLE_COLUMN_EVENTS_MESSAGE).invoke('text').should('equal', 'message');
+      removeColumn(TABLE_COLUMN_EVENTS_MESSAGE);
 
-    cy.get(DRAGGABLE_HEADER).should('have.length', numberOfTimelineColumns);
+      cy.get(DRAGGABLE_HEADER).should('have.length', expectedNumberOfTimelineColumns);
 
-    removeColumn(TABLE_COLUMN_EVENTS_MESSAGE);
-    reload(waitsForEventsToBeLoaded);
+      reload(waitsForEventsToBeLoaded);
 
-    cy.get(DRAGGABLE_HEADER).should('have.length', numberOfTimelineColumns - 1);
-    cy.get(DRAGGABLE_HEADER).each(($el) => {
-      expect($el.text()).not.equal('message');
+      cy.get(DRAGGABLE_HEADER).should('have.length', expectedNumberOfTimelineColumns);
+      cy.get(DRAGGABLE_HEADER).each(($el) => {
+        expect($el.text()).not.equal('message');
+      });
     });
   });
 });

x-pack/plugins/security_solution/cypress/tasks/timeline.ts

@@ -105,15 +105,9 @@ export const dragAndDropIdToggleFieldToTimeline = () => {
   );
 };
 
-export const waitForTimelineActionToFinish = () => {
-  cy.get(TIMELINE_COLUMN_SPINNER).should('exist');
-  cy.get(TIMELINE_COLUMN_SPINNER).should('not.exist');
-};
-
 export const removeColumn = (column: number) => {
   cy.get(REMOVE_COLUMN).first().should('exist');
   cy.get(REMOVE_COLUMN).eq(column).click({ force: true });
-  waitForTimelineActionToFinish();
 };
 
 export const resetFields = () => {