address PR feedback

Author: legrego

x-pack/plugins/security/index.js

@@ -83,23 +83,10 @@ export const security = (kibana) => new kibana.Plugin({
       const config = server.config();
 
       return {
-        showUserProfile: true,
         secureCookies: config.get('xpack.security.secureCookies'),
         sessionTimeout: config.get('xpack.security.sessionTimeout'),
         enableSpaceAwarePrivileges: config.get('xpack.spaces.enabled'),
       };
-    },
-    replaceInjectedVars: function (vars, request) {
-      const { settings } = request.route;
-      // Don't show user profile if requested page is not authenticated.
-      // (there won't be a user...)
-      if (settings.auth === false) {
-        return {
-          ...vars,
-          showUserProfile: false,
-        };
-      }
-      return vars;
     }
   },
 

x-pack/plugins/spaces/public/views/nav_control/nav_control.tsx

@@ -57,7 +57,7 @@ module.controller(
     let mounted = false;
 
     $scope.$parent.$watch('isVisible', function isVisibleWatcher(isVisible: boolean) {
-      if (isVisible && !mounted && !pathProvider.isStatusPage()) {
+      if (isVisible && !mounted && !pathProvider.isUnauthenticated()) {
         render(
           <NavControlPopover
             spacesManager={spacesManager}
@@ -102,6 +102,11 @@ chromeHeaderNavControlsRegistry.register(
     side: NavControlSide.Left,
     render(el: HTMLElement) {
       const userProfile = Private(UserProfileProvider);
+      const pathProvider = Private(PathProvider);
+
+      if (pathProvider.isUnauthenticated()) {
+        return;
+      }
 
       const spaceSelectorURL = chrome.getInjected('spaceSelectorURL');