Skip to content

Commit 34c99cb

Browse files
Revert changes to use_kibana_ui_setting (#50877)
1 parent eb4c47e commit 34c99cb

File tree

1 file changed

+9
-9
lines changed

1 file changed

+9
-9
lines changed

x-pack/legacy/plugins/siem/public/lib/settings/use_kibana_ui_setting.ts

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -34,22 +34,22 @@ export const useKibanaUiSetting = (key: string, defaultValue?: GenericValue) =>
3434
const core = useKibanaCore();
3535
const uiSettingsClient = core.uiSettings;
3636
const uiInjectedMetadata = core.injectedMetadata;
37-
const uiSetting$ = useMemo(() => uiSettingsClient.get$(key, defaultValue), [uiSettingsClient]);
38-
const uiSetting = useObservable(uiSetting$);
39-
const setUiSetting = useCallback((value: GenericValue) => uiSettingsClient.set(key, value), [
40-
uiSettingsClient,
41-
]);
42-
const defaultTimezoneProvider = useMemo(() => timezoneProvider(uiSettingsClient)(), [
43-
uiSettingsClient,
44-
]);
4537

4638
if (key === DEFAULT_KBN_VERSION) {
4739
return [uiInjectedMetadata.getKibanaVersion()];
4840
}
4941

42+
/* eslint-disable react-hooks/rules-of-hooks */
5043
if (key === DEFAULT_TIMEZONE_BROWSER) {
51-
return [defaultTimezoneProvider];
44+
return [useMemo(() => timezoneProvider(uiSettingsClient)(), [uiSettingsClient])];
5245
}
5346

47+
const uiSetting$ = useMemo(() => uiSettingsClient.get$(key, defaultValue), [uiSettingsClient]);
48+
const uiSetting = useObservable(uiSetting$);
49+
const setUiSetting = useCallback((value: GenericValue) => uiSettingsClient.set(key, value), [
50+
uiSettingsClient,
51+
]);
52+
/* eslint-enable react-hooks/rules-of-hooks */
53+
5454
return [uiSetting, setUiSetting];
5555
};

0 commit comments

Comments
 (0)