Skip to content

Commit 330a9bb

Browse files
committed
Merge branch 'master' into update-reason-string
2 parents eb0a737 + 2fe56f9 commit 330a9bb

31 files changed

+414
-245
lines changed
Lines changed: 26 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,26 @@
1+
# Synchronize all pushes to 'master' branch with 'main' branch to facilitate migration
2+
name: "Sync main branch"
3+
on:
4+
push:
5+
branches:
6+
- master
7+
8+
jobs:
9+
sync_latest_from_upstream:
10+
runs-on: ubuntu-latest
11+
name: Sync latest commits from master branch
12+
13+
steps:
14+
- name: Checkout target repo
15+
uses: actions/checkout@v2
16+
with:
17+
ref: main
18+
19+
- name: Sync upstream changes
20+
id: sync
21+
uses: aormsby/Fork-Sync-With-Upstream-action@v3.0
22+
with:
23+
target_sync_branch: main
24+
target_repo_token: ${{ secrets.KIBANAMACHINE_TOKEN }}
25+
upstream_sync_branch: master
26+
upstream_sync_repo: elastic/kibana

docs/apm/correlations.asciidoc

Lines changed: 12 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -12,34 +12,33 @@ piece of hardware, like a host or pod. Or, perhaps a set of users, based on IP
1212
address or region, is facing increased latency due to local data center issues.
1313

1414
To find correlations, select a service on the *Services* page in the {apm-app}
15-
and click **View correlations**.
15+
then select a transaction group from the *Transactions* tab.
1616

1717
NOTE: Queries within the {apm-app} are also applied to the correlations.
1818

1919
[discrete]
2020
[[correlations-latency]]
2121
==== Find high transaction latency correlations
2222

23-
The correlations on the *Latency* tab help you discover which attributes are
24-
contributing to increased transaction latency.
23+
The correlations on the *Latency correlations* tab help you discover which
24+
attributes are contributing to increased transaction latency.
2525

2626
[role="screenshot"]
2727
image::apm/images/correlations-hover.png[Latency correlations]
2828

2929
The progress bar indicates the status of the asynchronous analysis, which
3030
performs statistical searches across a large number of attributes. For large
31-
time ranges and services with high transaction throughput this might take some
32-
time. To improve performance, reduce the time range on the service overview
33-
page.
31+
time ranges and services with high transaction throughput, this might take some
32+
time. To improve performance, reduce the time range.
3433

3534
The latency distribution chart visualizes the overall latency of the
36-
transactions in the service. If there are attributes that have a statistically
37-
significant correlation with slow response times, they are listed in a table
38-
below the chart. The table is sorted by correlation coefficients that range from
39-
0 to 1. Attributes with higher correlation values are more likely to contribute
40-
to high latency transactions. By default, the attribute with the highest
41-
correlation value is added to the chart. To see the latency distribution for
42-
other attributes, hover over their row in the table.
35+
transactions in the transaction group. If there are attributes that have a
36+
statistically significant correlation with slow response times, they are listed
37+
in a table below the chart. The table is sorted by correlation coefficients that
38+
range from 0 to 1. Attributes with higher correlation values are more likely to
39+
contribute to high latency transactions. By default, the attribute with the
40+
highest correlation value is added to the chart. To see the latency distribution
41+
for other attributes, hover over their row in the table.
4342

4443
If a correlated attribute seems noteworthy, use the **Filter** quick links:
4544

-148 KB
Loading

docs/settings/reporting-settings.asciidoc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -285,7 +285,7 @@ With Security enabled, Reporting has two forms of access control: each user can
285285

286286
[NOTE]
287287
============================================================================
288-
The `xpack.reporting.roles` settings are for a deprecated system of access control in Reporting. It does not allow API Keys to generate reports, and it doesn't allow {kib} application privileges. We recommend you explicitly turn off reporting's deprecated access control feature by adding `xpack.reporting.roles.enabled: false` in kibana.yml. This will enable application privileges for reporting, as described in <<grant-user-access, granting users access to reporting>>.
288+
The `xpack.reporting.roles` settings are for a deprecated system of access control in Reporting. It does not allow API Keys to generate reports, and it doesn't allow {kib} application privileges. We recommend you explicitly turn off reporting's deprecated access control feature by adding `xpack.reporting.roles.enabled: false` in kibana.yml. This will enable you to create custom roles that provide application privileges for reporting, as described in <<grant-user-access, granting users access to reporting>>.
289289
============================================================================
290290

291291
[[xpack-reporting-roles-enabled]] `xpack.reporting.roles.enabled`::

packages/kbn-dev-utils/src/ci_stats_reporter/ci_stats_reporter.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -221,11 +221,12 @@ export class CiStatsReporter {
221221
? `${error.response.status} response`
222222
: 'no response';
223223

224+
const seconds = attempt * 10;
224225
this.log.warning(
225-
`failed to reach ci-stats service [reason=${reason}], retrying in ${attempt} seconds`
226+
`failed to reach ci-stats service, retrying in ${seconds} seconds, [reason=${reason}], [error=${error.message}]`
226227
);
227228

228-
await new Promise((resolve) => setTimeout(resolve, attempt * 1000));
229+
await new Promise((resolve) => setTimeout(resolve, seconds * 1000));
229230
}
230231
}
231232
}

packages/kbn-pm/dist/index.js

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -59656,8 +59656,9 @@ class CiStatsReporter {
5965659656

5965759657

5965859658
const reason = error !== null && error !== void 0 && (_error$response = error.response) !== null && _error$response !== void 0 && _error$response.status ? `${error.response.status} response` : 'no response';
59659-
this.log.warning(`failed to reach ci-stats service [reason=${reason}], retrying in ${attempt} seconds`);
59660-
await new Promise(resolve => setTimeout(resolve, attempt * 1000));
59659+
const seconds = attempt * 10;
59660+
this.log.warning(`failed to reach ci-stats service, retrying in ${seconds} seconds, [reason=${reason}], [error=${error.message}]`);
59661+
await new Promise(resolve => setTimeout(resolve, seconds * 1000));
5966159662
}
5966259663
}
5966359664
}

test/scripts/jenkins_apm_cypress.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ echo " -> Running APM cypress tests"
66
cd "$XPACK_DIR"
77

88
checks-reporter-with-killswitch "APM Cypress Tests" \
9-
node plugins/apm/scripts/ftr_e2e/cypress_run
9+
node plugins/apm/scripts/test/e2e.js
1010

1111
echo ""
1212
echo ""

x-pack/plugins/alerting/server/health/get_state.test.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -216,8 +216,8 @@ describe('getHealthServiceStatusWithRetryAndErrorHandling', () => {
216216
})
217217
).toPromise();
218218

219-
expect(status.level).toEqual(ServiceStatusLevels.unavailable);
220-
expect(status.summary).toEqual('Alerting framework is unavailable');
219+
expect(status.level).toEqual(ServiceStatusLevels.degraded);
220+
expect(status.summary).toEqual('Alerting framework is degraded');
221221
expect(status.meta).toBeUndefined();
222222
});
223223

@@ -275,8 +275,8 @@ describe('getHealthServiceStatusWithRetryAndErrorHandling', () => {
275275
}),
276276
retryDelay
277277
).subscribe((status) => {
278-
expect(status.level).toEqual(ServiceStatusLevels.unavailable);
279-
expect(status.summary).toEqual('Alerting framework is unavailable');
278+
expect(status.level).toEqual(ServiceStatusLevels.degraded);
279+
expect(status.summary).toEqual('Alerting framework is degraded');
280280
expect(status.meta).toEqual({ error: err });
281281
});
282282

x-pack/plugins/alerting/server/health/get_state.ts

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -73,9 +73,7 @@ const getHealthServiceStatus = async (
7373
const level =
7474
doc.state?.health_status === HealthStatus.OK
7575
? ServiceStatusLevels.available
76-
: doc.state?.health_status === HealthStatus.Warning
77-
? ServiceStatusLevels.degraded
78-
: ServiceStatusLevels.unavailable;
76+
: ServiceStatusLevels.degraded;
7977
return {
8078
level,
8179
summary: LEVEL_SUMMARY[level.toString()],
@@ -102,10 +100,10 @@ export const getHealthServiceStatusWithRetryAndErrorHandling = (
102100
);
103101
}),
104102
catchError((error) => {
105-
logger.warn(`Alerting framework is unavailable due to the error: ${error}`);
103+
logger.warn(`Alerting framework is degraded due to the error: ${error}`);
106104
return of({
107-
level: ServiceStatusLevels.unavailable,
108-
summary: LEVEL_SUMMARY[ServiceStatusLevels.unavailable.toString()],
105+
level: ServiceStatusLevels.degraded,
106+
summary: LEVEL_SUMMARY[ServiceStatusLevels.degraded.toString()],
109107
meta: { error },
110108
});
111109
})

x-pack/plugins/alerting/server/plugin.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -240,7 +240,7 @@ export class AlertingPlugin {
240240
);
241241

242242
const serviceStatus$ = new BehaviorSubject<ServiceStatus>({
243-
level: ServiceStatusLevels.unavailable,
243+
level: ServiceStatusLevels.degraded,
244244
summary: 'Alerting is initializing',
245245
});
246246
core.status.set(serviceStatus$);

0 commit comments

Comments
 (0)