Skip to content

Commit 32ab9b2

Browse files
committed
revert unnecessary changes
1 parent 6b7cd05 commit 32ab9b2

File tree

4 files changed

+45
-20
lines changed

4 files changed

+45
-20
lines changed

x-pack/plugins/apm/public/components/app/RumDashboard/PageLoadDistribution/index.tsx

Lines changed: 20 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -6,37 +6,44 @@
66

77
import React, { useState } from 'react';
88
import { EuiFlexGroup, EuiFlexItem, EuiSpacer, EuiTitle } from '@elastic/eui';
9+
import { useUrlParams } from '../../../../hooks/useUrlParams';
910
import { useFetcher } from '../../../../hooks/useFetcher';
1011
import { I18LABELS } from '../translations';
1112
import { BreakdownFilter } from '../Breakdowns/BreakdownFilter';
1213
import { PageLoadDistChart } from '../Charts/PageLoadDistChart';
1314
import { BreakdownItem } from '../../../../../typings/ui_filters';
1415
import { ResetPercentileZoom } from './ResetPercentileZoom';
15-
import { useUxQuery } from '../hooks/useUxQuery';
1616

1717
export interface PercentileRange {
1818
min?: number | null;
1919
max?: number | null;
2020
}
2121

2222
export function PageLoadDistribution() {
23+
const { urlParams, uiFilters } = useUrlParams();
24+
25+
const { start, end, searchTerm } = urlParams;
26+
2327
const [percentileRange, setPercentileRange] = useState<PercentileRange>({
2428
min: null,
2529
max: null,
2630
});
2731

2832
const [breakdown, setBreakdown] = useState<BreakdownItem | null>(null);
2933

30-
const uxQuery = useUxQuery();
31-
3234
const { data, status } = useFetcher(
3335
(callApmApi) => {
34-
if (uxQuery) {
36+
const { serviceName } = uiFilters;
37+
38+
if (start && end && serviceName) {
3539
return callApmApi({
3640
pathname: '/api/apm/rum-client/page-load-distribution',
3741
params: {
3842
query: {
39-
...uxQuery,
43+
start,
44+
end,
45+
uiFilters: JSON.stringify(uiFilters),
46+
urlQuery: searchTerm,
4047
...(percentileRange.min && percentileRange.max
4148
? {
4249
minPercentile: String(percentileRange.min),
@@ -49,7 +56,14 @@ export function PageLoadDistribution() {
4956
}
5057
return Promise.resolve(null);
5158
},
52-
[uxQuery, percentileRange.min, percentileRange.max]
59+
[
60+
end,
61+
start,
62+
uiFilters,
63+
percentileRange.min,
64+
percentileRange.max,
65+
searchTerm,
66+
]
5367
);
5468

5569
const onPercentileChange = (min: number, max: number) => {

x-pack/plugins/apm/public/components/app/RumDashboard/PageViewsTrend/index.tsx

Lines changed: 12 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -6,26 +6,33 @@
66

77
import React, { useState } from 'react';
88
import { EuiFlexGroup, EuiFlexItem, EuiSpacer, EuiTitle } from '@elastic/eui';
9+
import { useUrlParams } from '../../../../hooks/useUrlParams';
910
import { useFetcher } from '../../../../hooks/useFetcher';
1011
import { I18LABELS } from '../translations';
1112
import { BreakdownFilter } from '../Breakdowns/BreakdownFilter';
1213
import { PageViewsChart } from '../Charts/PageViewsChart';
1314
import { BreakdownItem } from '../../../../../typings/ui_filters';
14-
import { useUxQuery } from '../hooks/useUxQuery';
1515

1616
export function PageViewsTrend() {
17-
const uxQuery = useUxQuery();
17+
const { urlParams, uiFilters } = useUrlParams();
18+
19+
const { start, end, searchTerm } = urlParams;
1820

1921
const [breakdown, setBreakdown] = useState<BreakdownItem | null>(null);
2022

2123
const { data, status } = useFetcher(
2224
(callApmApi) => {
23-
if (uxQuery) {
25+
const { serviceName } = uiFilters;
26+
27+
if (start && end && serviceName) {
2428
return callApmApi({
2529
pathname: '/api/apm/rum-client/page-view-trends',
2630
params: {
2731
query: {
28-
...uxQuery,
32+
start,
33+
end,
34+
uiFilters: JSON.stringify(uiFilters),
35+
urlQuery: searchTerm,
2936
...(breakdown
3037
? {
3138
breakdowns: JSON.stringify(breakdown),
@@ -37,7 +44,7 @@ export function PageViewsTrend() {
3744
}
3845
return Promise.resolve(undefined);
3946
},
40-
[uxQuery, breakdown]
47+
[end, start, uiFilters, breakdown, searchTerm]
4148
);
4249

4350
return (

x-pack/plugins/apm/public/components/app/RumDashboard/VisitorBreakdown/index.tsx

Lines changed: 12 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -9,26 +9,33 @@ import { EuiFlexGroup, EuiFlexItem, EuiTitle, EuiSpacer } from '@elastic/eui';
99
import { VisitorBreakdownChart } from '../Charts/VisitorBreakdownChart';
1010
import { I18LABELS, VisitorBreakdownLabel } from '../translations';
1111
import { useFetcher } from '../../../../hooks/useFetcher';
12-
import { useUxQuery } from '../hooks/useUxQuery';
12+
import { useUrlParams } from '../../../../hooks/useUrlParams';
1313

1414
export function VisitorBreakdown() {
15-
const uxQuery = useUxQuery();
15+
const { urlParams, uiFilters } = useUrlParams();
16+
17+
const { start, end, searchTerm } = urlParams;
1618

1719
const { data, status } = useFetcher(
1820
(callApmApi) => {
19-
if (uxQuery) {
21+
const { serviceName } = uiFilters;
22+
23+
if (start && end && serviceName) {
2024
return callApmApi({
2125
pathname: '/api/apm/rum-client/visitor-breakdown',
2226
params: {
2327
query: {
24-
...uxQuery,
28+
start,
29+
end,
30+
uiFilters: JSON.stringify(uiFilters),
31+
urlQuery: searchTerm,
2532
},
2633
},
2734
});
2835
}
2936
return Promise.resolve(null);
3037
},
31-
[uxQuery]
38+
[end, start, uiFilters, searchTerm]
3239
);
3340

3441
return (

x-pack/plugins/apm/server/routes/rum_client.ts

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -26,10 +26,7 @@ export const percentileRangeRt = t.partial({
2626
const uxQueryRt = t.intersection([
2727
uiFiltersRt,
2828
rangeRt,
29-
t.type({
30-
percentile: t.string,
31-
}),
32-
t.partial({ urlQuery: t.string }),
29+
t.partial({ urlQuery: t.string, percentile: t.string }),
3330
]);
3431

3532
export const rumClientMetricsRoute = createRoute(() => ({

0 commit comments

Comments
 (0)