Skip to content

Commit 31501a7

Browse files
committed
Fix EnginesOverview tests
1 parent 3a9aba7 commit 31501a7

File tree

2 files changed

+9
-11
lines changed

2 files changed

+9
-11
lines changed

x-pack/plugins/enterprise_search/public/applications/app_search/components/engines/engines_overview.test.tsx

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
*/
66

77
import '../../../__mocks__/shallow_useeffect.mock';
8-
import { setMockValues, setMockActions, rerender, mockKibanaValues } from '../../../__mocks__';
8+
import { setMockValues, setMockActions, rerender } from '../../../__mocks__';
99

1010
import React from 'react';
1111
import { shallow, ShallowWrapper } from 'enzyme';
@@ -76,12 +76,11 @@ describe('EnginesOverview', () => {
7676
});
7777

7878
it('renders a create engine button which takes users to the create engine page', () => {
79-
const { navigateToUrl } = mockKibanaValues;
8079
const wrapper = shallow(<EnginesOverview />);
8180

82-
wrapper.find('[data-test-subj="appSearchEnginesEngineCreationButton"]').simulate('click');
83-
84-
expect(navigateToUrl).toHaveBeenCalledWith('/engine_creation');
81+
expect(
82+
wrapper.find('[data-test-subj="appSearchEnginesEngineCreationButton"]').prop('to')
83+
).toEqual('/engine_creation');
8584
});
8685

8786
describe('when on a platinum license', () => {

x-pack/plugins/enterprise_search/public/applications/app_search/components/engines/engines_overview.tsx

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77
import React, { useEffect } from 'react';
88
import { useValues, useActions } from 'kea';
99
import {
10-
EuiButton,
1110
EuiPageContent,
1211
EuiPageContentHeader,
1312
EuiPageContentHeaderSection,
@@ -20,8 +19,8 @@ import { SetAppSearchChrome as SetPageChrome } from '../../../shared/kibana_chro
2019
import { SendAppSearchTelemetry as SendTelemetry } from '../../../shared/telemetry';
2120
import { FlashMessages } from '../../../shared/flash_messages';
2221
import { LicensingLogic } from '../../../shared/licensing';
22+
import { EuiButtonTo } from '../../../shared/react_router_helpers';
2323
import { ENGINE_CREATION_PATH } from '../../routes';
24-
import { KibanaLogic } from '../../../shared/kibana';
2524

2625
import { EngineIcon } from './assets/engine_icon';
2726
import { MetaEngineIcon } from './assets/meta_engine_icon';
@@ -75,14 +74,14 @@ export const EnginesOverview: React.FC = () => {
7574
</EuiTitle>
7675
</EuiPageContentHeaderSection>
7776
<EuiPageContentHeaderSection>
78-
<EuiButton
79-
color="secondary"
77+
<EuiButtonTo
78+
color="primary"
8079
fill
8180
data-test-subj="appSearchEnginesEngineCreationButton"
82-
onClick={() => KibanaLogic.values.navigateToUrl(ENGINE_CREATION_PATH)}
81+
to={ENGINE_CREATION_PATH}
8382
>
8483
{CREATE_AN_ENGINE_BUTTON_LABEL}
85-
</EuiButton>
84+
</EuiButtonTo>
8685
</EuiPageContentHeaderSection>
8786
</EuiPageContentHeader>
8887
<EuiPageContentBody data-test-subj="appSearchEngines">

0 commit comments

Comments
 (0)