Skip to content

Commit 31057f7

Browse files
[APM] "Backends" naming (#110523)
* renaming backends to dependencies * changing name on service maps
1 parent 5b6588d commit 31057f7

File tree

11 files changed

+30
-25
lines changed

11 files changed

+30
-25
lines changed

x-pack/plugins/apm/common/backends.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,9 +14,9 @@ import {
1414
import { environmentQuery } from './utils/environment_query';
1515

1616
export const kueryBarPlaceholder = i18n.translate(
17-
'xpack.apm.backends.kueryBarPlaceholder',
17+
'xpack.apm.dependencies.kueryBarPlaceholder',
1818
{
19-
defaultMessage: `Search backend metrics (e.g. span.destination.service.resource:elasticsearch)`,
19+
defaultMessage: `Search dependency metrics (e.g. span.destination.service.resource:elasticsearch)`,
2020
}
2121
);
2222

x-pack/plugins/apm/ftr_e2e/cypress/integration/read_only_user/service_overview/service_overview.spec.ts

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,6 +74,10 @@ describe('Service Overview', () => {
7474
cy.contains('Service Map');
7575
// Waits until the agent request is finished to check the tab.
7676
cy.wait('@agentRequest');
77-
cy.contains('Dependencies').should('not.exist');
77+
cy.get('.euiTabs .euiTab__content').then((elements) => {
78+
elements.map((index, element) => {
79+
expect(element.innerText).to.not.equal('Dependencies');
80+
});
81+
});
7882
});
7983
});

x-pack/plugins/apm/public/components/app/backend_detail_overview/index.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ import { useApmParams } from '../../../hooks/use_apm_params';
1818
import { useApmRouter } from '../../../hooks/use_apm_router';
1919
import { SearchBar } from '../../shared/search_bar';
2020
import { BackendLatencyChart } from './backend_latency_chart';
21-
import { BackendInventoryTitle } from '../../routing/home';
21+
import { DependenciesInventoryTitle } from '../../routing/home';
2222
import { BackendDetailDependenciesTable } from './backend_detail_dependencies_table';
2323
import { BackendThroughputChart } from './backend_throughput_chart';
2424
import { BackendFailedTransactionRateChart } from './backend_error_rate_chart';
@@ -39,7 +39,7 @@ export function BackendDetailOverview() {
3939

4040
useBreadcrumb([
4141
{
42-
title: BackendInventoryTitle,
42+
title: DependenciesInventoryTitle,
4343
href: apmRouter.link('/backends', {
4444
query: { rangeFrom, rangeTo, environment, kuery },
4545
}),

x-pack/plugins/apm/public/components/app/backend_inventory/backend_inventory_dependencies_table/index.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -98,9 +98,9 @@ export function BackendInventoryDependenciesTable() {
9898
dependencies={dependencies}
9999
title={null}
100100
nameColumnTitle={i18n.translate(
101-
'xpack.apm.backendInventory.dependenciesTableColumnBackend',
101+
'xpack.apm.backendInventory.dependencyTableColumn',
102102
{
103-
defaultMessage: 'Backend',
103+
defaultMessage: 'Dependency',
104104
}
105105
)}
106106
status={status}

x-pack/plugins/apm/public/components/app/service_map/Popover/backend_contents.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -85,8 +85,8 @@ export function BackendContents({
8585
});
8686
}}
8787
>
88-
{i18n.translate('xpack.apm.serviceMap.backendDetailsButtonText', {
89-
defaultMessage: 'Backend Details',
88+
{i18n.translate('xpack.apm.serviceMap.dependencyDetailsButtonText', {
89+
defaultMessage: 'Dependency Details',
9090
})}
9191
</EuiButton>
9292
</EuiFlexItem>

x-pack/plugins/apm/public/components/app/service_map/Popover/popover.test.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,12 +14,12 @@ const { Backend, ExternalsList, Resource, Service } = composeStories(stories);
1414

1515
describe('Popover', () => {
1616
describe('with backend data', () => {
17-
it('renders a backend link', async () => {
17+
it('renders a dependency link', async () => {
1818
render(<Backend />);
1919

2020
await waitFor(() => {
2121
expect(
22-
screen.getByRole('link', { name: /backend details/i })
22+
screen.getByRole('link', { name: /Dependency Details/i })
2323
).toBeInTheDocument();
2424
});
2525
});

x-pack/plugins/apm/public/components/app/service_overview/service_overview_dependencies_table/index.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -125,13 +125,13 @@ export function ServiceOverviewDependenciesTable({
125125
title={i18n.translate(
126126
'xpack.apm.serviceOverview.dependenciesTableTitle',
127127
{
128-
defaultMessage: 'Downstream services and backends',
128+
defaultMessage: 'Dependencies',
129129
}
130130
)}
131131
nameColumnTitle={i18n.translate(
132-
'xpack.apm.serviceOverview.dependenciesTableColumnBackend',
132+
'xpack.apm.serviceOverview.dependenciesTableColumn',
133133
{
134-
defaultMessage: 'Backend',
134+
defaultMessage: 'Dependency',
135135
}
136136
)}
137137
status={status}

x-pack/plugins/apm/public/components/routing/home/index.tsx

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -45,10 +45,10 @@ export const ServiceInventoryTitle = i18n.translate(
4545
}
4646
);
4747

48-
export const BackendInventoryTitle = i18n.translate(
49-
'xpack.apm.views.backendInventory.title',
48+
export const DependenciesInventoryTitle = i18n.translate(
49+
'xpack.apm.views.dependenciesInventory.title',
5050
{
51-
defaultMessage: 'Backends',
51+
defaultMessage: 'Dependencies',
5252
}
5353
);
5454

@@ -114,7 +114,7 @@ export const home = {
114114
},
115115
page({
116116
path: '/',
117-
title: BackendInventoryTitle,
117+
title: DependenciesInventoryTitle,
118118
element: <BackendInventory />,
119119
}),
120120
],

x-pack/plugins/apm/public/plugin.ts

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -93,9 +93,12 @@ const serviceMapTitle = i18n.translate('xpack.apm.navigation.serviceMapTitle', {
9393
defaultMessage: 'Service Map',
9494
});
9595

96-
const backendsTitle = i18n.translate('xpack.apm.navigation.backendsTitle', {
97-
defaultMessage: 'Backends',
98-
});
96+
const dependenciesTitle = i18n.translate(
97+
'xpack.apm.navigation.dependenciesTitle',
98+
{
99+
defaultMessage: 'Dependencies',
100+
}
101+
);
99102

100103
export class ApmPlugin implements Plugin<ApmPluginSetup, ApmPluginStart> {
101104
constructor(
@@ -126,7 +129,7 @@ export class ApmPlugin implements Plugin<ApmPluginSetup, ApmPluginStart> {
126129
{ label: servicesTitle, app: 'apm', path: '/services' },
127130
{ label: tracesTitle, app: 'apm', path: '/traces' },
128131
{
129-
label: backendsTitle,
132+
label: dependenciesTitle,
130133
app: 'apm',
131134
path: '/backends',
132135
isNewFeature: true,
@@ -270,7 +273,7 @@ export class ApmPlugin implements Plugin<ApmPluginSetup, ApmPluginStart> {
270273
{ id: 'services', title: servicesTitle, path: '/services' },
271274
{ id: 'traces', title: tracesTitle, path: '/traces' },
272275
{ id: 'service-map', title: serviceMapTitle, path: '/service-map' },
273-
{ id: 'backends', title: backendsTitle, path: '/backends' },
276+
{ id: 'backends', title: dependenciesTitle, path: '/backends' },
274277
],
275278

276279
async mount(appMountParameters: AppMountParameters<unknown>) {

x-pack/plugins/translations/translations/ja-JP.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5657,7 +5657,6 @@
56575657
"xpack.apm.serviceNodeMetrics.unidentifiedServiceNodesWarningTitle": "JVM を特定できませんでした",
56585658
"xpack.apm.serviceNodeNameMissing": " (空) ",
56595659
"xpack.apm.serviceOveriew.errorsTableOccurrences": "{occurrencesCount} occ.",
5660-
"xpack.apm.serviceOverview.dependenciesTableColumnBackend": "バックエンド",
56615660
"xpack.apm.serviceOverview.dependenciesTableTitle": "依存関係",
56625661
"xpack.apm.serviceOverview.errorsTableColumnLastSeen": "前回の認識",
56635662
"xpack.apm.serviceOverview.errorsTableColumnName": "名前",

0 commit comments

Comments
 (0)