Skip to content

Commit 304445f

Browse files
authored
fix: πŸ› don't show actions if Discover app is disabled (#73017)
* fix: πŸ› don't show actions if Discover app is disabled * style: collapse ifs
1 parent 49782f9 commit 304445f

File tree

3 files changed

+31
-1
lines changed

3 files changed

+31
-1
lines changed

β€Žx-pack/plugins/discover_enhanced/public/actions/explore_data/abstract_explore_data_action.tsβ€Ž

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,12 +49,16 @@ export abstract class AbstractExploreDataAction<Context extends { embeddable?: I
4949
public async isCompatible({ embeddable }: Context): Promise<boolean> {
5050
if (!embeddable) return false;
5151

52+
const { core, plugins } = this.params.start();
53+
const { capabilities } = core.application;
54+
55+
if (capabilities.discover && !capabilities.discover.show) return false;
56+
if (!plugins.discover.urlGenerator) return false;
5257
const isDashboardOnlyMode = !!this.params
5358
.start()
5459
.plugins.kibanaLegacy?.dashboardConfig.getHideWriteControls();
5560
if (isDashboardOnlyMode) return false;
5661

57-
if (!this.params.start().plugins.discover.urlGenerator) return false;
5862
if (!shared.hasExactlyOneIndexPattern(embeddable)) return false;
5963
if (embeddable.getInput().viewMode !== ViewMode.VIEW) return false;
6064
return true;

β€Žx-pack/plugins/discover_enhanced/public/actions/explore_data/explore_data_chart_action.test.tsβ€Ž

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -196,6 +196,19 @@ describe('"Explore underlying data" panel action', () => {
196196

197197
expect(isCompatible).toBe(false);
198198
});
199+
200+
test('returns false if Discover app is disabled', async () => {
201+
const { action, context, core } = setup();
202+
203+
core.application.capabilities = { ...core.application.capabilities };
204+
(core.application.capabilities as any).discover = {
205+
show: false,
206+
};
207+
208+
const isCompatible = await action.isCompatible(context);
209+
210+
expect(isCompatible).toBe(false);
211+
});
199212
});
200213

201214
describe('getHref()', () => {

β€Žx-pack/plugins/discover_enhanced/public/actions/explore_data/explore_data_context_menu_action.test.tsβ€Ž

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -179,6 +179,19 @@ describe('"Explore underlying data" panel action', () => {
179179

180180
expect(isCompatible).toBe(false);
181181
});
182+
183+
test('returns false if Discover app is disabled', async () => {
184+
const { action, context, core } = setup();
185+
186+
core.application.capabilities = { ...core.application.capabilities };
187+
(core.application.capabilities as any).discover = {
188+
show: false,
189+
};
190+
191+
const isCompatible = await action.isCompatible(context);
192+
193+
expect(isCompatible).toBe(false);
194+
});
182195
});
183196

184197
describe('getHref()', () => {

0 commit comments

Comments
Β (0)