rename doc button and refactor type map const name

Author: jloleysens

x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/processor_settings_form/learn_more_form_button.tsx renamed to x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/processor_settings_form/documentation_button.tsx

@@ -13,7 +13,7 @@ interface Props {
   docLink: string;
 }
 
-export const LearnMoreFormButton: FunctionComponent<Props> = ({ processorLabel, docLink }) => {
+export const DocumentationButton: FunctionComponent<Props> = ({ processorLabel, docLink }) => {
   return (
     <EuiButtonEmpty size="s" flush="right" href={docLink} target="_blank" iconType="help">
       {i18n.translate(

x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/processor_settings_form/map_processor_type_to_form.tsx

@@ -19,7 +19,7 @@ interface FieldsFormDescriptor {
   label: string;
 }
 
-const mapProcessorTypeToFormOrDocPath: Record<string, FieldsFormDescriptor> = {
+const mapProcessorTypeToFormDescriptor: Record<string, FieldsFormDescriptor> = {
   append: {
     FieldsComponent: undefined, // TODO: Implement
     docLinkPath: '/append-processor.html',
@@ -262,12 +262,12 @@ const mapProcessorTypeToFormOrDocPath: Record<string, FieldsFormDescriptor> = {
   },
 };
 
-export const types = Object.keys(mapProcessorTypeToFormOrDocPath).sort();
+export const types = Object.keys(mapProcessorTypeToFormDescriptor).sort();
 
-export type ProcessorType = keyof typeof mapProcessorTypeToFormOrDocPath;
+export type ProcessorType = keyof typeof mapProcessorTypeToFormDescriptor;
 
 export const getProcessorFormDescriptor = (
   type: ProcessorType | string
 ): FieldsFormDescriptor | undefined => {
-  return mapProcessorTypeToFormOrDocPath[type as ProcessorType];
+  return mapProcessorTypeToFormDescriptor[type as ProcessorType];
 };

x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/processor_settings_form/processor_settings_form.tsx

@@ -22,7 +22,7 @@ import { Form, useForm, FormDataProvider } from '../../../../../shared_imports';
 import { usePipelineProcessorsContext } from '../../context';
 import { ProcessorInternal } from '../../types';
 
-import { LearnMoreFormButton } from './learn_more_form_button';
+import { DocumentationButton } from './documentation_button';
 import { ProcessorSettingsFromOnSubmitArg } from './processor_settings_form.container';
 import { getProcessorFormDescriptor } from './map_processor_type_to_form';
 import { CommonProcessorFields, ProcessorTypeField } from './processors/common_fields';
@@ -83,7 +83,7 @@ export const ProcessorSettingsForm: FunctionComponent<Props> = memo(
 
                     if (formDescriptor) {
                       return (
-                        <LearnMoreFormButton
+                        <DocumentationButton
                           processorLabel={formDescriptor.label}
                           docLink={esDocsBasePath + formDescriptor.docLinkPath}
                         />