Skip to content

Commit 2e7b8fc

Browse files
Merge branch 'master' into hosts-overview-search-strategy
2 parents 2129502 + 68a9838 commit 2e7b8fc

File tree

29 files changed

+1313
-764
lines changed

29 files changed

+1313
-764
lines changed

src/plugins/data/public/public.api.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1465,7 +1465,7 @@ export interface QueryState {
14651465
// Warning: (ae-missing-release-tag) "QueryStringInput" is exported by the package, but it is missing a release tag (@alpha, @beta, @public, or @internal)
14661466
//
14671467
// @public (undocumented)
1468-
export const QueryStringInput: React.FC<Pick<Props_3, "query" | "prepend" | "size" | "placeholder" | "onChange" | "onBlur" | "onSubmit" | "indexPatterns" | "dataTestSubj" | "screenTitle" | "disableAutoFocus" | "persistedLog" | "bubbleSubmitEvent" | "languageSwitcherPopoverAnchorPosition" | "onChangeQueryInputFocus">>;
1468+
export const QueryStringInput: React.FC<Pick<Props_3, "query" | "prepend" | "size" | "className" | "placeholder" | "onChange" | "onBlur" | "onSubmit" | "indexPatterns" | "dataTestSubj" | "screenTitle" | "disableAutoFocus" | "persistedLog" | "bubbleSubmitEvent" | "languageSwitcherPopoverAnchorPosition" | "onChangeQueryInputFocus">>;
14691469

14701470
// @public (undocumented)
14711471
export type QuerySuggestion = QuerySuggestionBasic | QuerySuggestionField;

src/plugins/data/public/ui/query_string_input/query_string_input.tsx

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919

2020
import React, { Component, RefObject, createRef } from 'react';
2121
import { i18n } from '@kbn/i18n';
22-
22+
import classNames from 'classnames';
2323
import {
2424
EuiTextArea,
2525
EuiOutsideClickDetector,
@@ -62,6 +62,7 @@ interface Props {
6262
onSubmit?: (query: Query) => void;
6363
dataTestSubj?: string;
6464
size?: SuggestionsListSize;
65+
className?: string;
6566
}
6667

6768
interface State {
@@ -586,9 +587,12 @@ export class QueryStringInputUI extends Component<Props, State> {
586587
'aria-owns': 'kbnTypeahead__items',
587588
};
588589
const ariaCombobox = { ...isSuggestionsVisible, role: 'combobox' };
589-
590+
const className = classNames(
591+
'euiFormControlLayout euiFormControlLayout--group kbnQueryBar__wrap',
592+
this.props.className
593+
);
590594
return (
591-
<div className="euiFormControlLayout euiFormControlLayout--group kbnQueryBar__wrap">
595+
<div className={className}>
592596
{this.props.prepend}
593597
<EuiOutsideClickDetector onOutsideClick={this.onOutsideClick}>
594598
<div

test/functional/apps/visualize/_vega_chart.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -50,8 +50,7 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) {
5050
const retry = getService('retry');
5151
const browser = getService('browser');
5252

53-
// FLAKY: https://github.com/elastic/kibana/issues/75699
54-
describe.skip('vega chart in visualize app', () => {
53+
describe('vega chart in visualize app', () => {
5554
before(async () => {
5655
log.debug('navigateToApp visualize');
5756
await PageObjects.visualize.navigateToNewVisualization();

test/functional/page_objects/vega_chart_page.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -94,8 +94,9 @@ export function VegaChartPageProvider({
9494
const aceGutter = await this.getAceGutterContainer();
9595

9696
await aceGutter.doubleClick();
97-
await browser.pressKeys(Key.LEFT);
9897
await browser.pressKeys(Key.RIGHT);
98+
await browser.pressKeys(Key.LEFT);
99+
await browser.pressKeys(Key.LEFT);
99100
await browser.pressKeys(text);
100101
}
101102

test/scripts/jenkins_security_solution_cypress.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,11 +5,11 @@ source test/scripts/jenkins_test_setup_xpack.sh
55
echo " -> Running security solution cypress tests"
66
cd "$XPACK_DIR"
77

8-
checks-reporter-with-killswitch "Security solution Cypress Tests" \
8+
checks-reporter-with-killswitch "Security Solution Cypress Tests" \
99
node scripts/functional_tests \
1010
--debug --bail \
1111
--kibana-install-dir "$KIBANA_INSTALL_DIR" \
12-
--config test/security_solution_cypress/config.ts
12+
--config test/security_solution_cypress/cli_config.ts
1313

1414
echo ""
1515
echo ""

x-pack/plugins/infra/server/lib/alerting/log_threshold/log_threshold_chart_preview.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -50,8 +50,8 @@ export async function getChartPreviewData(
5050
const { rangeFilter } = buildFiltersFromCriteria(expandedAlertParams, timestampField);
5151

5252
const query = isGrouped
53-
? getGroupedESQuery(expandedAlertParams, sourceConfiguration.configuration, indexPattern)
54-
: getUngroupedESQuery(expandedAlertParams, sourceConfiguration.configuration, indexPattern);
53+
? getGroupedESQuery(expandedAlertParams, timestampField, indexPattern)
54+
: getUngroupedESQuery(expandedAlertParams, timestampField, indexPattern);
5555

5656
if (!query) {
5757
throw new Error('ES query could not be built from the provided alert params');

0 commit comments

Comments
 (0)