Merge branch 'master' into event-log/rx-buffer

Author: kibanamachine

.ci/Dockerfile

@@ -1,7 +1,7 @@
 # NOTE: This Dockerfile is ONLY used to run certain tasks in CI. It is not used to run Kibana or as a distributable.
 # If you're looking for the Kibana Docker image distributable, please see: src/dev/build/tasks/os_packages/docker_generator/templates/dockerfile.template.ts
 
-ARG NODE_VERSION=12.19.0
+ARG NODE_VERSION=12.19.1
 
 FROM node:${NODE_VERSION} AS base
 

.ci/build_docker.sh

@@ -0,0 +1,10 @@
+#!/bin/bash
+
+set -euo pipefail
+
+cd "$(dirname "${0}")"
+
+cp /usr/local/bin/runbld ./
+cp /usr/local/bin/bash_standard_lib.sh ./
+
+docker build -t kibana-ci -f ./Dockerfile .

.ci/packer_cache_for_branch.sh

@@ -53,6 +53,8 @@ tar -cf "$HOME/.kibana/bootstrap_cache/$branch.tar" \
 
 echo "created $HOME/.kibana/bootstrap_cache/$branch.tar"
 
+.ci/build_docker.sh
+
 if [[ "$branch" != "master" ]]; then
   rm --preserve-root -rf "$checkoutDir"
 fi

.eslintrc.js

@@ -863,7 +863,8 @@ module.exports = {
         'no-shadow-restricted-names': 'error',
         'no-sparse-arrays': 'error',
         'no-this-before-super': 'error',
-        'no-undef': 'error',
+        // rely on typescript
+        'no-undef': 'off',
         'no-unreachable': 'error',
         'no-unsafe-finally': 'error',
         'no-useless-call': 'error',
@@ -998,7 +999,8 @@ module.exports = {
         'no-shadow-restricted-names': 'error',
         'no-sparse-arrays': 'error',
         'no-this-before-super': 'error',
-        'no-undef': 'error',
+        // rely on typescript
+        'no-undef': 'off',
         'no-unreachable': 'error',
         'no-unsafe-finally': 'error',
         'no-useless-call': 'error',

.github/CODEOWNERS

@@ -9,6 +9,7 @@
 /x-pack/plugins/discover_enhanced/ @elastic/kibana-app
 /x-pack/plugins/lens/ @elastic/kibana-app
 /x-pack/plugins/graph/ @elastic/kibana-app
+/x-pack/plugins/vis_type_timeseries_enhanced/ @elastic/kibana-app
 /src/plugins/advanced_settings/ @elastic/kibana-app
 /src/plugins/charts/ @elastic/kibana-app
 /src/plugins/discover/ @elastic/kibana-app
@@ -29,40 +30,40 @@
 /src/plugins/visualizations/ @elastic/kibana-app
 
 # Application Services
-/examples/bfetch_explorer/ @elastic/kibana-app-arch
-/examples/dashboard_embeddable_examples/ @elastic/kibana-app-arch
-/examples/demo_search/ @elastic/kibana-app-arch
-/examples/developer_examples/ @elastic/kibana-app-arch
-/examples/embeddable_examples/ @elastic/kibana-app-arch
-/examples/embeddable_explorer/ @elastic/kibana-app-arch
-/examples/state_containers_examples/ @elastic/kibana-app-arch
-/examples/ui_action_examples/ @elastic/kibana-app-arch
-/examples/ui_actions_explorer/ @elastic/kibana-app-arch
-/examples/url_generators_examples/ @elastic/kibana-app-arch
-/examples/url_generators_explorer/ @elastic/kibana-app-arch
-/packages/elastic-datemath/ @elastic/kibana-app-arch
-/packages/kbn-interpreter/ @elastic/kibana-app-arch
-/src/plugins/bfetch/ @elastic/kibana-app-arch
-/src/plugins/data/ @elastic/kibana-app-arch
-/src/plugins/embeddable/ @elastic/kibana-app-arch
-/src/plugins/expressions/ @elastic/kibana-app-arch
-/src/plugins/inspector/ @elastic/kibana-app-arch
-/src/plugins/kibana_react/ @elastic/kibana-app-arch
+/examples/bfetch_explorer/ @elastic/kibana-app-services
+/examples/dashboard_embeddable_examples/ @elastic/kibana-app-services
+/examples/demo_search/ @elastic/kibana-app-services
+/examples/developer_examples/ @elastic/kibana-app-services
+/examples/embeddable_examples/ @elastic/kibana-app-services
+/examples/embeddable_explorer/ @elastic/kibana-app-services
+/examples/state_containers_examples/ @elastic/kibana-app-services
+/examples/ui_action_examples/ @elastic/kibana-app-services
+/examples/ui_actions_explorer/ @elastic/kibana-app-services
+/examples/url_generators_examples/ @elastic/kibana-app-services
+/examples/url_generators_explorer/ @elastic/kibana-app-services
+/packages/elastic-datemath/ @elastic/kibana-app-services
+/packages/kbn-interpreter/ @elastic/kibana-app-services
+/src/plugins/bfetch/ @elastic/kibana-app-services
+/src/plugins/data/ @elastic/kibana-app-services
+/src/plugins/embeddable/ @elastic/kibana-app-services
+/src/plugins/expressions/ @elastic/kibana-app-services
+/src/plugins/inspector/ @elastic/kibana-app-services
+/src/plugins/kibana_react/ @elastic/kibana-app-services
 /src/plugins/kibana_react/public/code_editor @elastic/kibana-presentation
-/src/plugins/kibana_utils/ @elastic/kibana-app-arch
-/src/plugins/navigation/ @elastic/kibana-app-arch
-/src/plugins/share/ @elastic/kibana-app-arch
-/src/plugins/ui_actions/ @elastic/kibana-app-arch
-/x-pack/examples/ui_actions_enhanced_examples/ @elastic/kibana-app-arch
-/x-pack/plugins/data_enhanced/ @elastic/kibana-app-arch
-/x-pack/plugins/embeddable_enhanced/ @elastic/kibana-app-arch
-/x-pack/plugins/ui_actions_enhanced/ @elastic/kibana-app-arch
-#CC# /src/plugins/bfetch/ @elastic/kibana-app-arch
-#CC# /src/plugins/index_pattern_management/ @elastic/kibana-app-arch
-#CC# /src/plugins/inspector/ @elastic/kibana-app-arch
-#CC# /src/plugins/share/ @elastic/kibana-app-arch
-#CC# /x-pack/plugins/drilldowns/ @elastic/kibana-app-arch
-#CC# /packages/kbn-interpreter/ @elastic/kibana-app-arch
+/src/plugins/kibana_utils/ @elastic/kibana-app-services
+/src/plugins/navigation/ @elastic/kibana-app-services
+/src/plugins/share/ @elastic/kibana-app-services
+/src/plugins/ui_actions/ @elastic/kibana-app-services
+/x-pack/examples/ui_actions_enhanced_examples/ @elastic/kibana-app-services
+/x-pack/plugins/data_enhanced/ @elastic/kibana-app-services
+/x-pack/plugins/embeddable_enhanced/ @elastic/kibana-app-services
+/x-pack/plugins/ui_actions_enhanced/ @elastic/kibana-app-services
+#CC# /src/plugins/bfetch/ @elastic/kibana-app-services
+#CC# /src/plugins/index_pattern_management/ @elastic/kibana-app-services
+#CC# /src/plugins/inspector/ @elastic/kibana-app-services
+#CC# /src/plugins/share/ @elastic/kibana-app-services
+#CC# /x-pack/plugins/drilldowns/ @elastic/kibana-app-services
+#CC# /packages/kbn-interpreter/ @elastic/kibana-app-services
 
 # APM
 /x-pack/plugins/apm/  @elastic/apm-ui
@@ -158,7 +159,7 @@
 /packages/kbn-ui-shared-deps/ @elastic/kibana-operations
 /packages/kbn-es-archiver/ @elastic/kibana-operations
 /packages/kbn-utils/ @elastic/kibana-operations
-/src/legacy/server/keystore/ @elastic/kibana-operations
+/src/cli/keystore/ @elastic/kibana-operations
 /src/legacy/server/warnings/ @elastic/kibana-operations
 /.ci/es-snapshots/ @elastic/kibana-operations
 /vars/ @elastic/kibana-operations
@@ -171,38 +172,38 @@
 /test/functional/services/lib @elastic/kibana-qa
 /test/functional/services/remote @elastic/kibana-qa
 
-# Platform
-/src/core/  @elastic/kibana-platform
-/src/plugins/saved_objects_tagging_oss  @elastic/kibana-platform
-/config/kibana.yml @elastic/kibana-platform
-/x-pack/plugins/features/  @elastic/kibana-platform
-/x-pack/plugins/licensing/  @elastic/kibana-platform
-/x-pack/plugins/global_search/  @elastic/kibana-platform
-/x-pack/plugins/cloud/ @elastic/kibana-platform
-/x-pack/plugins/saved_objects_tagging/ @elastic/kibana-platform
-/x-pack/test/saved_objects_field_count/ @elastic/kibana-platform
-/x-pack/test/saved_object_tagging/ @elastic/kibana-platform
-/packages/kbn-config-schema/ @elastic/kibana-platform
-/packages/kbn-std/ @elastic/kibana-platform
-/src/legacy/server/config/ @elastic/kibana-platform
-/src/legacy/server/http/ @elastic/kibana-platform
-/src/legacy/server/logging/ @elastic/kibana-platform
-/src/plugins/status_page/ @elastic/kibana-platform
-/src/plugins/saved_objects_management/ @elastic/kibana-platform
-/src/dev/run_check_published_api_changes.ts @elastic/kibana-platform
-#CC# /src/core/server/csp/ @elastic/kibana-platform
-#CC# /src/legacy/server/config/ @elastic/kibana-platform
-#CC# /src/legacy/server/http/ @elastic/kibana-platform
-#CC# /src/legacy/ui/public/documentation_links @elastic/kibana-platform
-#CC# /src/plugins/legacy_export/ @elastic/kibana-platform
-#CC# /src/plugins/saved_objects/ @elastic/kibana-platform
-#CC# /src/plugins/status_page/ @elastic/kibana-platform
-#CC# /x-pack/plugins/cloud/ @elastic/kibana-platform
-#CC# /x-pack/plugins/features/ @elastic/kibana-platform
-#CC# /x-pack/plugins/global_search/ @elastic/kibana-platform
+# Core
+/src/core/  @elastic/kibana-core
+/src/plugins/saved_objects_tagging_oss  @elastic/kibana-core
+/config/kibana.yml @elastic/kibana-core
+/x-pack/plugins/features/  @elastic/kibana-core
+/x-pack/plugins/licensing/  @elastic/kibana-core
+/x-pack/plugins/global_search/  @elastic/kibana-core
+/x-pack/plugins/cloud/ @elastic/kibana-core
+/x-pack/plugins/saved_objects_tagging/ @elastic/kibana-core
+/x-pack/test/saved_objects_field_count/ @elastic/kibana-core
+/x-pack/test/saved_object_tagging/ @elastic/kibana-core
+/packages/kbn-config-schema/ @elastic/kibana-core
+/packages/kbn-std/ @elastic/kibana-core
+/src/legacy/server/config/ @elastic/kibana-core
+/src/legacy/server/http/ @elastic/kibana-core
+/src/legacy/server/logging/ @elastic/kibana-core
+/src/plugins/status_page/ @elastic/kibana-core
+/src/plugins/saved_objects_management/ @elastic/kibana-core
+/src/dev/run_check_published_api_changes.ts @elastic/kibana-core
+#CC# /src/core/server/csp/ @elastic/kibana-core
+#CC# /src/legacy/server/config/ @elastic/kibana-core
+#CC# /src/legacy/server/http/ @elastic/kibana-core
+#CC# /src/legacy/ui/public/documentation_links @elastic/kibana-core
+#CC# /src/plugins/legacy_export/ @elastic/kibana-core
+#CC# /src/plugins/saved_objects/ @elastic/kibana-core
+#CC# /src/plugins/status_page/ @elastic/kibana-core
+#CC# /x-pack/plugins/cloud/ @elastic/kibana-core
+#CC# /x-pack/plugins/features/ @elastic/kibana-core
+#CC# /x-pack/plugins/global_search/ @elastic/kibana-core
 
 # Security
-/src/core/server/csp/  @elastic/kibana-security @elastic/kibana-platform
+/src/core/server/csp/  @elastic/kibana-security @elastic/kibana-core
 /src/plugins/security_oss/ @elastic/kibana-security
 /test/security_functional/ @elastic/kibana-security
 /x-pack/plugins/spaces/  @elastic/kibana-security

.node-version

@@ -1 +1 @@
-12.19.0
+12.19.1

.nvmrc

@@ -1 +1 @@
-12.19.0
+12.19.1

docs/developer/architecture/security/feature-registration.asciidoc

@@ -198,7 +198,10 @@ server.route({
 === Example 3: Discover
 
 Discover takes advantage of subfeature privileges to allow fine-grained access control. In this example,
-a single "Create Short URLs" subfeature privilege is defined, which allows users to grant access to this feature without having to grant the `all` privilege to Discover. In other words, you can grant `read` access to Discover, and also grant the ability to create short URLs.
+two subfeature privileges are defined: "Create Short URLs", and "Generate PDF Reports". These allow users to grant access to this feature without having to grant the `all` privilege to Discover. In other words, you can grant `read` access to Discover, and also grant the ability to create short URLs or generate PDF reports.
+
+Notice the "Generate PDF Reports" subfeature privilege has an additional `minimumPrivilege` option. Kibana will only offer this subfeature privilege if the
+license requirement is satisfied.
 
 ["source","javascript"]
 -----------
@@ -259,6 +262,28 @@ public setup(core, { features }) {
                 },
               ],
             },
+            {
+              groupType: 'independent',
+              privileges: [
+                {
+                  id: 'pdf_generate',
+                  name: i18n.translate(
+                    'xpack.features.ossFeatures.discoverGeneratePDFReportsPrivilegeName',
+                    {
+                      defaultMessage: 'Generate PDF Reports',
+                    }
+                  ),
+                  minimumLicense: 'platinum',
+                  includeIn: 'all',
+                  savedObject: {
+                    all: [],
+                    read: [],
+                  },
+                  api: ['generatePDFReports'],
+                  ui: ['generatePDFReports'],
+                },
+              ],
+            },
           ],
         },
       ],

docs/developer/contributing/index.asciidoc

@@ -2,7 +2,7 @@
 == Contributing
 
 Whether you want to fix a bug, implement a feature, or add some other improvements or apis, the following sections will 
-guide you on the process.
+guide you on the process. After committing your code, check out the link:https://www.elastic.co/community/contributor[Elastic Contributor Program] where you can earn points and rewards for your contributions.
 
 Read <<development-getting-started>> to get your environment up and running, then read <<development-best-practices>>.
 

docs/developer/plugin-list.asciidoc

@@ -479,6 +479,10 @@ Elastic.
 |Welcome to the Kibana rollup plugin! This plugin provides Kibana support for Elasticsearch's rollup feature. Please refer to the Elasticsearch documentation to understand rollup indices and how to create rollup jobs.
 
 
+|{kib-repo}blob/{branch}/x-pack/plugins/runtime_fields/README.md[runtimeFields]
+|Welcome to the home of the runtime field editor and everything related to runtime fields!
+
+
 |{kib-repo}blob/{branch}/x-pack/plugins/saved_objects_tagging/README.md[savedObjectsTagging]
 |Add tagging capability to saved objects
 
@@ -554,6 +558,10 @@ in their infrastructure.
 |NOTE: This plugin contains implementation of URL drilldown. For drilldowns infrastructure code refer to ui_actions_enhanced plugin.
 
 
+|{kib-repo}blob/{branch}/x-pack/plugins/vis_type_timeseries_enhanced/README.md[visTypeTimeseriesEnhanced]
+|The vis_type_timeseries_enhanced plugin is the x-pack counterpart to the OSS vis_type_timeseries plugin.
+
+
 |{kib-repo}blob/{branch}/x-pack/plugins/watcher/README.md[watcher]
 |This plugins adopts some conventions in addition to or in place of conventions in Kibana (at the time of the plugin's creation):