Skip to content

Commit 2cb943e

Browse files
authored
[Security Solution][Detections] Removes ML Job Settings SIEM copy and fixes link to ML app for creating custom jobs (#76595) (#76721)
## Summary Resolves elastic/security-team#199 Removes remaining SIEM copy and fixes link to ML app for creating custom jobs <p align="center"> <img width="500" src="https://user-images.githubusercontent.com/2946766/92073438-e017d600-ed70-11ea-9827-7b5c9ffab7b1.gif" /> </p> ### Checklist Delete any items that are not applicable to this PR. - [X] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md) - [X] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
1 parent 3472572 commit 2cb943e

File tree

3 files changed

+9
-5
lines changed

3 files changed

+9
-5
lines changed

x-pack/plugins/security_solution/public/common/components/ml_popover/jobs_table/__snapshots__/jobs_table.test.tsx.snap

Lines changed: 5 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

x-pack/plugins/security_solution/public/common/components/ml_popover/jobs_table/jobs_table.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -125,7 +125,7 @@ export const JobsTableComponent = ({ isLoading, jobs, onJobStateChange }: JobTab
125125
columns={getJobsTableColumns(isLoading, onJobStateChange, basePath)}
126126
items={getPaginatedItems(jobs, pageIndex, pageSize)}
127127
loading={isLoading}
128-
noItemsMessage={<NoItemsMessage />}
128+
noItemsMessage={<NoItemsMessage basePath={basePath} />}
129129
pagination={pagination}
130130
responsive={false}
131131
onChange={({ page }: { page: { index: number } }) => {
@@ -141,13 +141,13 @@ export const JobsTable = React.memo(JobsTableComponent);
141141

142142
JobsTable.displayName = 'JobsTable';
143143

144-
export const NoItemsMessage = React.memo(() => (
144+
export const NoItemsMessage = React.memo(({ basePath }: { basePath: string }) => (
145145
<EuiEmptyPrompt
146146
title={<h3>{i18n.NO_ITEMS_TEXT}</h3>}
147147
titleSize="xs"
148148
actions={
149149
<EuiButton
150-
href="ml#/jobs/new_job/step/index_or_search"
150+
href={`${basePath}/app/ml#/jobs/new_job/step/index_or_search`}
151151
iconType="popout"
152152
iconSide="right"
153153
size="s"

x-pack/plugins/security_solution/public/common/components/ml_popover/jobs_table/translations.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ export const COLUMN_RUN_JOB = i18n.translate(
3030
export const NO_ITEMS_TEXT = i18n.translate(
3131
'xpack.securitySolution.components.mlPopup.jobsTable.noItemsDescription',
3232
{
33-
defaultMessage: 'No SIEM Machine Learning jobs found',
33+
defaultMessage: 'No Security Machine Learning jobs found',
3434
}
3535
);
3636

0 commit comments

Comments
 (0)