Skip to content

Commit 29e99c3

Browse files
committed
use promise.all and remove outdated comment
1 parent b3ec447 commit 29e99c3

File tree

1 file changed

+4
-8
lines changed

1 file changed

+4
-8
lines changed

x-pack/legacy/plugins/reporting/server/routes/generate_from_savedobject_immediate.ts

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -52,14 +52,10 @@ export function registerGenerateCsvFromSavedObjectImmediate(
5252
const logger = parentLogger.clone(['savedobject-csv']);
5353
const jobParams = getJobParamsFromRequest(request, { isImmediate: true });
5454

55-
/* TODO these functions should be made available in the export types registry:
56-
*
57-
* const { createJobFn, executeJobFn } = exportTypesRegistry.getById(CSV_FROM_SAVEDOBJECT_JOB_TYPE)
58-
*
59-
* Calling an execute job factory requires passing a browserDriverFactory option, so we should not call the factory from here
60-
*/
61-
const createJobFn = await createJobFactory(reporting, logger);
62-
const executeJobFn = await executeJobFactory(reporting, logger);
55+
const [createJobFn, executeJobFn] = await Promise.all([
56+
createJobFactory(reporting, logger),
57+
executeJobFactory(reporting, logger),
58+
]);
6359
const jobDocPayload: JobDocPayloadPanelCsv = await createJobFn(
6460
jobParams,
6561
request.headers,

0 commit comments

Comments
 (0)