removes usage of EventsProvider in vislib (#38533)

* removing EventsProvider usage in Vislib

Author: ppisljar

src/legacy/ui/public/vislib/__tests__/lib/axis/axis.js

@@ -101,7 +101,7 @@ describe('Vislib Axis Class Test Suite', function () {
   };
 
   beforeEach(ngMock.module('kibana'));
-  beforeEach(ngMock.inject(function (Private, $injector) {
+  beforeEach(ngMock.inject(function ($injector) {
     persistedState = new ($injector.get('PersistedState'))();
 
     el = d3.select('body').append('div')

src/legacy/ui/public/vislib/__tests__/lib/x_axis.js

@@ -106,7 +106,7 @@ describe('Vislib xAxis Class Test Suite', function () {
   };
 
   beforeEach(ngMock.module('kibana'));
-  beforeEach(ngMock.inject(function (Private, $injector) {
+  beforeEach(ngMock.inject(function ($injector) {
     persistedState = new ($injector.get('PersistedState'))();
 
     el = d3.select('body').append('div')

src/legacy/ui/public/vislib/__tests__/lib/y_axis.js

@@ -110,7 +110,7 @@ function createData(seriesData) {
 describe('Vislib yAxis Class Test Suite', function () {
   beforeEach(ngMock.module('kibana'));
 
-  beforeEach(ngMock.inject(function (Private, $injector) {
+  beforeEach(ngMock.inject(function ($injector) {
     persistedState = new ($injector.get('PersistedState'))();
 
     expect($('.y-axis-wrapper')).to.have.length(0);

src/legacy/ui/public/vislib/__tests__/vis.js

@@ -162,8 +162,8 @@ dataArray.forEach(function (data, i) {
       });
 
       afterEach(function () {
-        vis.off(beforeEvent);
-        vis.off(afterEvent);
+        vis.removeAllListeners(beforeEvent);
+        vis.removeAllListeners(afterEvent);
       });
 
       it('should add an event and its listeners', function () {
@@ -219,8 +219,8 @@ dataArray.forEach(function (data, i) {
       });
 
       afterEach(function () {
-        vis.off(beforeEvent);
-        vis.off(afterEvent);
+        vis.removeAllListeners(beforeEvent);
+        vis.removeAllListeners(afterEvent);
       });
 
       it('should remove a listener', function () {
@@ -241,7 +241,7 @@ dataArray.forEach(function (data, i) {
 
       it('should remove the event and all listeners when only event passed an argument', function () {
         const charts = vis.handler.charts;
-        vis.off(afterEvent);
+        vis.removeAllListeners(afterEvent);
 
         // should remove 'brush' event
         expect(vis.listeners(beforeEvent)).to.contain(listener2);

src/legacy/ui/public/vislib/lib/handler.js

@@ -156,7 +156,7 @@ export class Handler {
     chartSelection.each(function (chartData) {
       const chart = new self.ChartClass(self, this, chartData);
 
-      self.vis.activeEvents().forEach(function (event) {
+      self.vis.eventNames().forEach(function (event) {
         self.enable(event, chart);
       });
 

src/legacy/ui/public/vislib/vis.js

@@ -19,15 +19,17 @@
 
 import _ from 'lodash';
 import d3 from 'd3';
+import { EventEmitter } from 'events';
+import chrome from '../chrome';
 import { KbnError } from '../errors';
-import { EventsProvider } from '../events';
 import { VisConfig } from './lib/vis_config';
 import { Handler } from './lib/handler';
 import { setHierarchicalTooltipFormatter } from '../vis/components/tooltip/_hierarchical_tooltip_formatter';
 import { setPointSeriesTooltipFormatter } from '../vis/components/tooltip/_pointseries_tooltip_formatter';
 
-export function VislibVisProvider(Private, config) {
-  const Events = Private(EventsProvider);
+const config = chrome.getUiSettingsClient();
+
+export function VislibVisProvider(Private) {
 
   setHierarchicalTooltipFormatter(Private);
   setPointSeriesTooltipFormatter(Private);
@@ -40,9 +42,9 @@ export function VislibVisProvider(Private, config) {
    * @param $el {HTMLElement} jQuery selected HTML element
    * @param config {Object} Parameters that define the chart type and chart options
    */
-  class Vis extends Events {
+  class Vis extends EventEmitter {
     constructor($el, visConfigArgs) {
-      super(arguments);
+      super();
       this.el = $el.get ? $el.get(0) : $el;
       this.visConfigArgs = _.cloneDeep(visConfigArgs);
       this.visConfigArgs.dimmingOpacity = config.get('visualization:dimmingOpacity');
@@ -153,7 +155,7 @@ export function VislibVisProvider(Private, config) {
      */
     on(event, listener) {
       const first = this.listenerCount(event) === 0;
-      const ret = Events.prototype.on.call(this, event, listener);
+      const ret = EventEmitter.prototype.on.call(this, event, listener);
       const added = this.listenerCount(event) > 0;
 
       // if this is the first listener added for the event
@@ -172,13 +174,19 @@ export function VislibVisProvider(Private, config) {
      */
     off(event, listener) {
       const last = this.listenerCount(event) === 1;
-      const ret = Events.prototype.off.call(this, event, listener);
+      const ret = EventEmitter.prototype.off.call(this, event, listener);
       const removed = this.listenerCount(event) === 0;
 
       // Once all listeners are removed, disable the events in the handler
       if (last && removed && this.handler) this.handler.disable(event);
       return ret;
     }
+
+    removeAllListeners(event) {
+      const ret = EventEmitter.prototype.removeAllListeners.call(this, event);
+      this.handler.disable(event);
+      return ret;
+    }
   }
 
   return Vis;