small change to allow cloning to work with #61692

Author: ThomThomson

src/plugins/dashboard/public/application/actions/clone_panel_action.test.tsx

@@ -32,7 +32,6 @@ import { ClonePanelAction } from '.';
 
 // eslint-disable-next-line
 import { embeddablePluginMock } from 'src/plugins/embeddable/public/mocks';
-import { PLACEHOLDER_EMBEDDABLE } from '../embeddable/placeholder';
 
 const { setup, doStart } = embeddablePluginMock.createInstance();
 setup.registerEmbeddableFactory(
@@ -116,7 +115,7 @@ test('Clones an embeddable without a saved object ID', async () => {
 test('Clones an embeddable with a saved object ID', async () => {
   const dashboard = embeddable.getRoot() as IContainer;
   const panel = dashboard.getInput().panels[embeddable.id] as DashboardPanelState;
-  panel.savedObjectId = 'holySavedObjectBatman';
+  panel.explicitInput.savedObjectId = 'holySavedObjectBatman';
   const action = new ClonePanelAction(coreStart);
   // @ts-ignore
   const newPanel = await action.cloneEmbeddable(panel, embeddable.type);

src/plugins/dashboard/public/application/actions/clone_panel_action.tsx

@@ -23,7 +23,7 @@ import uuid from 'uuid';
 import { ActionByType, IncompatibleActionError } from '../../ui_actions_plugin';
 import { ViewMode, PanelState, IEmbeddable } from '../../embeddable_plugin';
 import { SavedObject } from '../../../../saved_objects/public';
-import { PanelNotFoundError } from '../../../../embeddable/public';
+import { PanelNotFoundError, EmbeddableInput } from '../../../../embeddable/public';
 import {
   placePanelBeside,
   IPanelPlacementBesideArgs,
@@ -125,19 +125,19 @@ export class ClonePanelAction implements ActionByType<typeof ACTION_CLONE_PANEL>
     panelToClone: DashboardPanelState,
     embeddableType: string
   ): Promise<Partial<PanelState>> {
-    const panelState: Partial<PanelState> = {
+    const panelState: PanelState<EmbeddableInput> = {
       type: embeddableType,
       explicitInput: {
         ...panelToClone.explicitInput,
         id: uuid.v4(),
       },
     };
     let newTitle: string = '';
-    if (panelToClone.savedObjectId) {
+    if (panelToClone.explicitInput.savedObjectId) {
       // Fetch existing saved object
       const savedObjectToClone = await this.core.savedObjects.client.get<SavedObject>(
         embeddableType,
-        panelToClone.savedObjectId
+        panelToClone.explicitInput.savedObjectId
       );
 
       // Clone the saved object
@@ -150,7 +150,7 @@ export class ClonePanelAction implements ActionByType<typeof ACTION_CLONE_PANEL>
         },
         { references: _.cloneDeep(savedObjectToClone.references) }
       );
-      panelState.savedObjectId = clonedSavedObject.id;
+      panelState.explicitInput.savedObjectId = clonedSavedObject.id;
     }
     this.core.notifications.toasts.addSuccess({
       title: i18n.translate('dashboard.panel.clonedToast', {