Skip to content

Commit 176d7e4

Browse files
Bump highlight.js to v9.18.5 (#84296)
1 parent e116fce commit 176d7e4

File tree

4 files changed

+65
-79
lines changed

4 files changed

+65
-79
lines changed

package.json

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -96,6 +96,8 @@
9696
"**/minimist": "^1.2.5",
9797
"**/node-jose/node-forge": "^0.10.0",
9898
"**/prismjs": "1.22.0",
99+
"**/react-syntax-highlighter": "^15.3.1",
100+
"**/react-syntax-highlighter/**/highlight.js": "^10.4.1",
99101
"**/request": "^2.88.2",
100102
"**/trim": "0.0.3",
101103
"**/typescript": "4.1.2"
@@ -680,7 +682,7 @@
680682
"has-ansi": "^3.0.0",
681683
"hdr-histogram-js": "^1.2.0",
682684
"he": "^1.2.0",
683-
"highlight.js": "9.15.10",
685+
"highlight.js": "^9.18.5",
684686
"history-extra": "^5.0.1",
685687
"hoist-non-react-statics": "^3.3.2",
686688
"html": "1.0.0",
@@ -784,7 +786,7 @@
784786
"react-router-redux": "^4.0.8",
785787
"react-shortcuts": "^2.0.0",
786788
"react-sizeme": "^2.3.6",
787-
"react-syntax-highlighter": "^5.7.0",
789+
"react-syntax-highlighter": "^15.3.1",
788790
"react-test-renderer": "^16.12.0",
789791
"react-tiny-virtual-list": "^2.2.0",
790792
"react-virtualized": "^9.21.2",

x-pack/plugins/apm/public/components/app/TransactionDetails/WaterfallWithSummmary/WaterfallContainer/Waterfall/SpanFlyout/DatabaseContext.tsx

Lines changed: 4 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -8,14 +8,9 @@ import { EuiSpacer, EuiTitle } from '@elastic/eui';
88
import { i18n } from '@kbn/i18n';
99
import { tint } from 'polished';
1010
import React, { Fragment } from 'react';
11-
// @ts-expect-error
12-
import sql from 'react-syntax-highlighter/dist/languages/sql';
13-
import SyntaxHighlighter, {
14-
registerLanguage,
15-
// @ts-expect-error
16-
} from 'react-syntax-highlighter/dist/light';
17-
// @ts-expect-error
18-
import { xcode } from 'react-syntax-highlighter/dist/styles';
11+
import sql from 'react-syntax-highlighter/dist/cjs/languages/hljs/sql';
12+
import xcode from 'react-syntax-highlighter/dist/cjs/styles/hljs/xcode';
13+
import { Light as SyntaxHighlighter } from 'react-syntax-highlighter';
1914
import styled from 'styled-components';
2015
import { Span } from '../../../../../../../../typings/es_schemas/ui/span';
2116
import {
@@ -28,7 +23,7 @@ import {
2823
} from '../../../../../../../style/variables';
2924
import { TruncateHeightSection } from './TruncateHeightSection';
3025

31-
registerLanguage('sql', sql);
26+
SyntaxHighlighter.registerLanguage('sql', sql);
3227

3328
const DatabaseStatement = styled.div`
3429
padding: ${px(units.half)} ${px(unit)};

x-pack/plugins/apm/public/components/shared/Stacktrace/Context.tsx

Lines changed: 12 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -7,26 +7,18 @@
77
import { size } from 'lodash';
88
import { tint } from 'polished';
99
import React from 'react';
10-
// TODO add dependency for @types/react-syntax-highlighter
11-
// @ts-expect-error
12-
import javascript from 'react-syntax-highlighter/dist/languages/javascript';
13-
// @ts-expect-error
14-
import python from 'react-syntax-highlighter/dist/languages/python';
15-
// @ts-expect-error
16-
import ruby from 'react-syntax-highlighter/dist/languages/ruby';
17-
// @ts-expect-error
18-
import SyntaxHighlighter from 'react-syntax-highlighter/dist/light';
19-
// @ts-expect-error
20-
import { registerLanguage } from 'react-syntax-highlighter/dist/light';
21-
// @ts-expect-error
22-
import { xcode } from 'react-syntax-highlighter/dist/styles';
10+
import javascript from 'react-syntax-highlighter/dist/cjs/languages/hljs/javascript';
11+
import python from 'react-syntax-highlighter/dist/cjs/languages/hljs/python';
12+
import ruby from 'react-syntax-highlighter/dist/cjs/languages/hljs/ruby';
13+
import xcode from 'react-syntax-highlighter/dist/cjs/styles/hljs/xcode';
14+
import { Light as SyntaxHighlighter } from 'react-syntax-highlighter';
2315
import styled from 'styled-components';
2416
import { StackframeWithLineContext } from '../../../../typings/es_schemas/raw/fields/stackframe';
2517
import { borderRadius, px, unit, units } from '../../../style/variables';
2618

27-
registerLanguage('javascript', javascript);
28-
registerLanguage('python', python);
29-
registerLanguage('ruby', ruby);
19+
SyntaxHighlighter.registerLanguage('javascript', javascript);
20+
SyntaxHighlighter.registerLanguage('python', python);
21+
SyntaxHighlighter.registerLanguage('ruby', ruby);
3022

3123
const ContextContainer = styled.div`
3224
position: relative;
@@ -106,7 +98,9 @@ function getStackframeLines(stackframe: StackframeWithLineContext) {
10698
const line = stackframe.line.context;
10799
const preLines = stackframe.context?.pre || [];
108100
const postLines = stackframe.context?.post || [];
109-
return [...preLines, line, ...postLines];
101+
return [...preLines, line, ...postLines].map(
102+
(x) => (x.endsWith('\n') ? x.slice(0, -1) : x) || ' '
103+
);
110104
}
111105

112106
function getStartLineNumber(stackframe: StackframeWithLineContext) {
@@ -146,7 +140,7 @@ export function Context({ stackframe, codeLanguage, isLibraryFrame }: Props) {
146140
CodeTag={Code}
147141
customStyle={{ padding: null, overflowX: null }}
148142
>
149-
{line || '\n'}
143+
{line}
150144
</SyntaxHighlighter>
151145
))}
152146
</LineContainer>

yarn.lock

Lines changed: 45 additions & 50 deletions
Original file line numberDiff line numberDiff line change
@@ -8055,7 +8055,7 @@ babel-preset-jest@^26.6.2:
80558055
babel-plugin-transform-undefined-to-void "^6.9.4"
80568056
lodash.isplainobject "^4.0.6"
80578057

8058-
babel-runtime@6.x, babel-runtime@^6.11.6, babel-runtime@^6.18.0, babel-runtime@^6.22.0, babel-runtime@^6.26.0:
8058+
babel-runtime@6.x, babel-runtime@^6.11.6, babel-runtime@^6.22.0, babel-runtime@^6.26.0:
80598059
version "6.26.0"
80608060
resolved "https://registry.yarnpkg.com/babel-runtime/-/babel-runtime-6.26.0.tgz#965c7058668e82b55d7bfe04ff2337bc8b5647fe"
80618061
integrity sha1-llxwWGaOgrVde/4E/yM3vItWR/4=
@@ -13478,7 +13478,7 @@ fastq@^1.6.0:
1347813478
dependencies:
1347913479
reusify "^1.0.0"
1348013480

13481-
fault@^1.0.2:
13481+
fault@^1.0.0:
1348213482
version "1.0.4"
1348313483
resolved "https://registry.yarnpkg.com/fault/-/fault-1.0.4.tgz#eafcfc0a6d214fc94601e170df29954a4f842f13"
1348413484
integrity sha512-CJ0HCB5tL5fYTEA7ToAq5+kTwd++Borf1/bifxd9iT70QcXr4MRrO3Llf8Ifs70q+SJcGHFtnIE/Nw6giCtECA==
@@ -15530,6 +15530,11 @@ hast-util-is-element@^1.0.0:
1553015530
resolved "https://registry.yarnpkg.com/hast-util-is-element/-/hast-util-is-element-1.0.4.tgz#059090a05cc02e275df1ad02caf8cb422fcd2e02"
1553115531
integrity sha512-NFR6ljJRvDcyPP5SbV7MyPBgF47X3BsskLnmw1U34yL+X6YC0MoBx9EyMg8Jtx4FzGH95jw8+c1VPLHaRA0wDQ==
1553215532

15533+
hast-util-parse-selector@^2.0.0:
15534+
version "2.2.3"
15535+
resolved "https://registry.yarnpkg.com/hast-util-parse-selector/-/hast-util-parse-selector-2.2.3.tgz#57edd449103900c7f63fd9e6f694ffd7e4634719"
15536+
integrity sha512-nxbeqjQNxsvo/uYYAw9kij6td05YVUlf1qti09rVfbWSLT5H6wo3c+USIwX6nzXWk5kFZzXnEqO82856r0aM2Q==
15537+
1553315538
hast-util-parse-selector@^2.2.0:
1553415539
version "2.2.1"
1553515540
resolved "https://registry.yarnpkg.com/hast-util-parse-selector/-/hast-util-parse-selector-2.2.1.tgz#4ddbae1ae12c124e3eb91b581d2556441766f0ab"
@@ -15609,6 +15614,17 @@ hastscript@^5.0.0:
1560915614
property-information "^5.0.1"
1561015615
space-separated-tokens "^1.0.0"
1561115616

15617+
hastscript@^6.0.0:
15618+
version "6.0.0"
15619+
resolved "https://registry.yarnpkg.com/hastscript/-/hastscript-6.0.0.tgz#e8768d7eac56c3fdeac8a92830d58e811e5bf640"
15620+
integrity sha512-nDM6bvd7lIqDUiYEiu5Sl/+6ReP0BMk/2f4U/Rooccxkj0P5nm+acM5PrGJ/t5I8qPGiqZSE6hVAwZEdZIvP4w==
15621+
dependencies:
15622+
"@types/hast" "^2.0.0"
15623+
comma-separated-tokens "^1.0.0"
15624+
hast-util-parse-selector "^2.0.0"
15625+
property-information "^5.0.0"
15626+
space-separated-tokens "^1.0.0"
15627+
1561215628
hat@0.0.3:
1561315629
version "0.0.3"
1561415630
resolved "https://registry.yarnpkg.com/hat/-/hat-0.0.3.tgz#bb014a9e64b3788aed8005917413d4ff3d502d8a"
@@ -15640,21 +15656,16 @@ heap@^0.2.6:
1564015656
resolved "https://registry.yarnpkg.com/heap/-/heap-0.2.6.tgz#087e1f10b046932fc8594dd9e6d378afc9d1e5ac"
1564115657
integrity sha1-CH4fELBGky/IWU3Z5tN4r8nR5aw=
1564215658

15643-
highlight.js@9.15.10, highlight.js@~9.15.0, highlight.js@~9.15.1:
15644-
version "9.15.10"
15645-
resolved "https://registry.yarnpkg.com/highlight.js/-/highlight.js-9.15.10.tgz#7b18ed75c90348c045eef9ed08ca1319a2219ad2"
15646-
integrity sha512-RoV7OkQm0T3os3Dd2VHLNMoaoDVx77Wygln3n9l5YV172XonWG6rgQD3XnF/BuFFZw9A0TJgmMSO8FEWQgvcXw==
15659+
highlight.js@^10.1.1, highlight.js@^10.4.1, highlight.js@~10.4.0:
15660+
version "10.4.1"
15661+
resolved "https://registry.yarnpkg.com/highlight.js/-/highlight.js-10.4.1.tgz#d48fbcf4a9971c4361b3f95f302747afe19dbad0"
15662+
integrity sha512-yR5lWvNz7c85OhVAEAeFhVCc/GV4C30Fjzc/rCP0aCWzc1UUOPUk55dK/qdwTZHBvMZo+eZ2jpk62ndX/xMFlg==
1564715663

1564815664
highlight.js@^9.18.5:
1564915665
version "9.18.5"
1565015666
resolved "https://registry.yarnpkg.com/highlight.js/-/highlight.js-9.18.5.tgz#d18a359867f378c138d6819edfc2a8acd5f29825"
1565115667
integrity sha512-a5bFyofd/BHCX52/8i8uJkjr9DYwXIPnM/plwI6W7ezItLGqzt7X2G2nXuYSfsIJdkwwj/g9DG1LkcGJI/dDoA==
1565215668

15653-
highlight.js@~9.12.0:
15654-
version "9.12.0"
15655-
resolved "https://registry.yarnpkg.com/highlight.js/-/highlight.js-9.12.0.tgz#e6d9dbe57cbefe60751f02af336195870c90c01e"
15656-
integrity sha1-5tnb5Xy+/mB1HwKvM2GVhwyQwB4=
15657-
1565815669
history-extra@^5.0.1:
1565915670
version "5.0.1"
1566015671
resolved "https://registry.yarnpkg.com/history-extra/-/history-extra-5.0.1.tgz#95a2e59dda526c4241d0ae1b124a77a5e4675ce8"
@@ -19325,20 +19336,13 @@ lowercase-keys@^2.0.0:
1932519336
resolved "https://registry.yarnpkg.com/lowercase-keys/-/lowercase-keys-2.0.0.tgz#2603e78b7b4b0006cbca2fbcc8a3202558ac9479"
1932619337
integrity sha512-tqNXrS78oMOE73NMxK4EMLQsQowWf8jKooH9g7xPavRT706R6bkQJ6DY2Te7QukaZsulxa30wQ7bk0pm4XiHmA==
1932719338

19328-
lowlight@1.12.1, lowlight@^1.2.0:
19329-
version "1.12.1"
19330-
resolved "https://registry.yarnpkg.com/lowlight/-/lowlight-1.12.1.tgz#014acf8dd73a370e02ff1cc61debcde3bb1681eb"
19331-
integrity sha512-OqaVxMGIESnawn+TU/QMV5BJLbUghUfjDWPAtFqDYDmDtr4FnB+op8xM+pR7nKlauHNUHXGt0VgWatFB8voS5w==
19339+
lowlight@^1.14.0, lowlight@^1.2.0:
19340+
version "1.17.0"
19341+
resolved "https://registry.yarnpkg.com/lowlight/-/lowlight-1.17.0.tgz#a1143b2fba8239df8cd5893f9fe97aaf8465af4a"
19342+
integrity sha512-vmtBgYKD+QVNy7tIa7ulz5d//Il9R4MooOVh4nkOf9R9Cb/Dk5TXMSTieg/vDulkBkIWj59/BIlyFQxT9X1oAQ==
1933219343
dependencies:
19333-
fault "^1.0.2"
19334-
highlight.js "~9.15.0"
19335-
19336-
lowlight@~1.9.1:
19337-
version "1.9.1"
19338-
resolved "https://registry.yarnpkg.com/lowlight/-/lowlight-1.9.1.tgz#ed7c3dffc36f8c1f263735c0fe0c907847c11250"
19339-
integrity sha512-CpDhyVhI+xHjruiGvH2F/Fr5q5aTn5A6Oyh7MI+4oI8G0A1E7p9a3Zqv9Hzx9WByK8gAiNifEueAXz+cA2xdEA==
19340-
dependencies:
19341-
highlight.js "~9.12.0"
19344+
fault "^1.0.0"
19345+
highlight.js "~10.4.0"
1934219346

1934319347
lru-cache@4.1.x, lru-cache@^4.0.0, lru-cache@^4.0.1, lru-cache@^4.1.5:
1934419348
version "4.1.5"
@@ -21645,7 +21649,7 @@ parse-color@^1.0.0:
2164521649
dependencies:
2164621650
color-convert "~0.5.0"
2164721651

21648-
parse-entities@^1.1.0, parse-entities@^1.1.2:
21652+
parse-entities@^1.1.0:
2164921653
version "1.2.1"
2165021654
resolved "https://registry.yarnpkg.com/parse-entities/-/parse-entities-1.2.1.tgz#2c761ced065ba7dc68148580b5a225e4918cdd69"
2165121655
integrity sha512-NBWYLQm1KSoDKk7GAHyioLTvCZ5QjdH/ASBBQTD3iLiAWJXS5bg1jEWI8nIJ+vgVvsceBVBcDGRWSo0KVQBvvg==
@@ -22382,7 +22386,7 @@ pretty-ms@5.0.0:
2238222386
dependencies:
2238322387
parse-ms "^2.1.0"
2238422388

22385-
prismjs@1.22.0, prismjs@^1.8.4, prismjs@~1.16.0:
22389+
prismjs@1.22.0, prismjs@^1.22.0, prismjs@~1.22.0:
2238622390
version "1.22.0"
2238722391
resolved "https://registry.yarnpkg.com/prismjs/-/prismjs-1.22.0.tgz#73c3400afc58a823dd7eed023f8e1ce9fd8977fa"
2238822392
integrity sha512-lLJ/Wt9yy0AiSYBf212kK3mM5L8ycwlyTlSxHBAneXLR0nzFMlZ5y7riFPF3E33zXOF2IH95xdY5jIyZbM9z/w==
@@ -23462,25 +23466,16 @@ react-style-singleton@^2.1.0:
2346223466
invariant "^2.2.4"
2346323467
tslib "^1.0.0"
2346423468

23465-
react-syntax-highlighter@^12.2.1:
23466-
version "12.2.1"
23467-
resolved "https://registry.yarnpkg.com/react-syntax-highlighter/-/react-syntax-highlighter-12.2.1.tgz#14d78352da1c1c3f93c6698b70ec7c706b83493e"
23468-
integrity sha512-CTsp0ZWijwKRYFg9xhkWD4DSpQqE4vb2NKVMdPAkomnILSmsNBHE0n5GuI5zB+PU3ySVvXvdt9jo+ViD9XibCA==
23469+
react-syntax-highlighter@^12.2.1, react-syntax-highlighter@^15.3.1:
23470+
version "15.3.1"
23471+
resolved "https://registry.yarnpkg.com/react-syntax-highlighter/-/react-syntax-highlighter-15.3.1.tgz#ba16ae8705f191956b73d0e11ae938fd255f2579"
23472+
integrity sha512-XVQuug7kQ4/cWxiYE0XfGXvbDqLLqRsMK/GpmD3v1WOLzb6REcgkL59cJo0m3Y2LB0eoRCNhV62jqQe9/Z0p9w==
2346923473
dependencies:
2347023474
"@babel/runtime" "^7.3.1"
23471-
highlight.js "~9.15.1"
23472-
lowlight "1.12.1"
23473-
prismjs "^1.8.4"
23474-
refractor "^2.4.1"
23475-
23476-
react-syntax-highlighter@^5.7.0:
23477-
version "5.8.0"
23478-
resolved "https://registry.yarnpkg.com/react-syntax-highlighter/-/react-syntax-highlighter-5.8.0.tgz#a220c010fd0641751d93532509ba7159cc3a4383"
23479-
integrity sha512-+FolT9NhFBqE4SsZDelSzsYJJS/JCnQqo4+GxLrFPoML548uvr8f4Eh5nnd5o6ERKFW7ryiygOX9SPnxdnlpkg==
23480-
dependencies:
23481-
babel-runtime "^6.18.0"
23482-
highlight.js "~9.12.0"
23483-
lowlight "~1.9.1"
23475+
highlight.js "^10.1.1"
23476+
lowlight "^1.14.0"
23477+
prismjs "^1.22.0"
23478+
refractor "^3.2.0"
2348423479

2348523480
react-test-renderer@^16.0.0-0, react-test-renderer@^16.12.0:
2348623481
version "16.12.0"
@@ -23956,14 +23951,14 @@ reflect.ownkeys@^0.2.0:
2395623951
resolved "https://registry.yarnpkg.com/reflect.ownkeys/-/reflect.ownkeys-0.2.0.tgz#749aceec7f3fdf8b63f927a04809e90c5c0b3460"
2395723952
integrity sha1-dJrO7H8/34tj+SegSAnpDFwLNGA=
2395823953

23959-
refractor@^2.4.1:
23960-
version "2.8.0"
23961-
resolved "https://registry.yarnpkg.com/refractor/-/refractor-2.8.0.tgz#29d7b2254e823edd2e3e476af286af1c11472bfa"
23962-
integrity sha512-w+jG49/1MX60GeE9u8lyx1KYMBRdAHjOIfgcDJ0wq2ogOnEmab0MgIj+AtPq6kelw0mr1l9U0i2rFvLlOCkxiw==
23954+
refractor@^3.2.0:
23955+
version "3.2.0"
23956+
resolved "https://registry.yarnpkg.com/refractor/-/refractor-3.2.0.tgz#bc46f7cfbb6adbf45cd304e8e299b7fa854804e0"
23957+
integrity sha512-hSo+EyMIZTLBvNNgIU5lW4yjCzNYMZ4dcEhBq/3nReGfqzd2JfVhdlPDfU9rEsgcAyWx+OimIIUoL4ZU7NtYHQ==
2396323958
dependencies:
23964-
hastscript "^5.0.0"
23965-
parse-entities "^1.1.2"
23966-
prismjs "~1.16.0"
23959+
hastscript "^6.0.0"
23960+
parse-entities "^2.0.0"
23961+
prismjs "~1.22.0"
2396723962

2396823963
regedit@^3.0.3:
2396923964
version "3.0.3"

0 commit comments

Comments
 (0)