Skip to content

Commit 13d4bfe

Browse files
Spencerspalger
authored andcommitted
[ftr] migrate management services to FtrService class (#100521)
Co-authored-by: spalger <spalger@users.noreply.github.com>
1 parent 112e174 commit 13d4bfe

File tree

3 files changed

+23
-27
lines changed

3 files changed

+23
-27
lines changed

test/functional/services/index.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ import { FlyoutProvider } from './flyout';
3232
import { GlobalNavService } from './global_nav';
3333
import { InspectorProvider } from './inspector';
3434
import { FieldEditorService } from './field_editor';
35-
import { ManagementMenuProvider } from './management';
35+
import { ManagementMenuService } from './management';
3636
import { QueryBarProvider } from './query_bar';
3737
import { RemoteProvider } from './remote';
3838
import { RenderableProvider } from './renderable';
@@ -83,7 +83,7 @@ export const services = {
8383
savedQueryManagementComponent: SavedQueryManagementComponentProvider,
8484
elasticChart: ElasticChartProvider,
8585
supertest: KibanaSupertestProvider,
86-
managementMenu: ManagementMenuProvider,
86+
managementMenu: ManagementMenuService,
8787
monacoEditor: MonacoEditorProvider,
8888
MenuToggle: MenuToggleProvider,
8989
};

test/functional/services/management/index.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,4 +6,4 @@
66
* Side Public License, v 1.
77
*/
88

9-
export { ManagementMenuProvider } from './management_menu';
9+
export { ManagementMenuService } from './management_menu';

test/functional/services/management/management_menu.ts

Lines changed: 20 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -6,35 +6,31 @@
66
* Side Public License, v 1.
77
*/
88

9-
import { FtrProviderContext } from 'test/functional/ftr_provider_context';
9+
import { FtrService } from '../../ftr_provider_context';
1010

11-
export function ManagementMenuProvider({ getService }: FtrProviderContext) {
12-
const find = getService('find');
11+
export class ManagementMenuService extends FtrService {
12+
private readonly find = this.ctx.getService('find');
1313

14-
class ManagementMenu {
15-
public async getSections() {
16-
const sectionsElements = await find.allByCssSelector(
17-
'.mgtSideBarNav > .euiSideNav__content > .euiSideNavItem'
18-
);
19-
20-
const sections = [];
14+
public async getSections() {
15+
const sectionsElements = await this.find.allByCssSelector(
16+
'.mgtSideBarNav > .euiSideNav__content > .euiSideNavItem'
17+
);
2118

22-
for (const el of sectionsElements) {
23-
const sectionId = await (await el.findByClassName('euiSideNavItemButton')).getAttribute(
24-
'data-test-subj'
25-
);
26-
const sectionLinks = await Promise.all(
27-
(await el.findAllByCssSelector('.euiSideNavItem > a.euiSideNavItemButton')).map((item) =>
28-
item.getAttribute('data-test-subj')
29-
)
30-
);
19+
const sections = [];
3120

32-
sections.push({ sectionId, sectionLinks });
33-
}
21+
for (const el of sectionsElements) {
22+
const sectionId = await (await el.findByClassName('euiSideNavItemButton')).getAttribute(
23+
'data-test-subj'
24+
);
25+
const sectionLinks = await Promise.all(
26+
(await el.findAllByCssSelector('.euiSideNavItem > a.euiSideNavItemButton')).map((item) =>
27+
item.getAttribute('data-test-subj')
28+
)
29+
);
3430

35-
return sections;
31+
sections.push({ sectionId, sectionLinks });
3632
}
37-
}
3833

39-
return new ManagementMenu();
34+
return sections;
35+
}
4036
}

0 commit comments

Comments
 (0)