Fix es_ui_shared eslint violations for useRequest hook (#72947) (#76328)

* Reconcile request helpers with eslint rules for React hooks.
  - Add clearer cleanup logic for unmounted components.
  - Align logic and comments in np_ready_request.ts and original request.ts.
* Reorganize modules and convert tests to TS.
  - Split request.ts into send_request.ts and use_request.ts.
  - Convert test files into TS.
  - Relax SendRequestResponse type definition to type error as any instead of expecting an Error, since we weren't actually fulfilling this expectation.
* Convert everything to hooks and add test coverage for request behavior.
* Fix Watcher memoization bugs.
# Conflicts:
#	.eslintrc.js

Author: cjcenizal

.eslintrc.js

@@ -94,12 +94,6 @@ module.exports = {
         'jsx-a11y/no-onchange': 'off',
       },
     },
-    {
-      files: ['src/plugins/es_ui_shared/**/*.{js,mjs,ts,tsx}'],
-      rules: {
-        'react-hooks/exhaustive-deps': 'off',
-      },
-    },
     {
       files: ['src/plugins/eui_utils/**/*.{js,mjs,ts,tsx}'],
       rules: {
@@ -131,25 +125,12 @@ module.exports = {
         'jsx-a11y/click-events-have-key-events': 'off',
       },
     },
-    {
-      files: ['x-pack/legacy/plugins/index_management/**/*.{js,mjs,ts,tsx}'],
-      rules: {
-        'react-hooks/exhaustive-deps': 'off',
-        'react-hooks/rules-of-hooks': 'off',
-      },
-    },
     {
       files: ['x-pack/plugins/ml/**/*.{js,mjs,ts,tsx}'],
       rules: {
         'react-hooks/exhaustive-deps': 'off',
       },
     },
-    {
-      files: ['x-pack/legacy/plugins/snapshot_restore/**/*.{js,mjs,ts,tsx}'],
-      rules: {
-        'react-hooks/exhaustive-deps': 'off',
-      },
-    },
 
     /**
      * Files that require Apache 2.0 headers, settings

src/plugins/es_ui_shared/__packages_do_not_import__/global_flyout/global_flyout.tsx

@@ -160,6 +160,8 @@ export const useGlobalFlyout = () => {
         Array.from(getContents()).forEach(removeContent);
       }
     };
+    // https://github.com/elastic/kibana/issues/73970
+    /* eslint-disable-next-line react-hooks/exhaustive-deps */
   }, [removeContent]);
 
   return { ...ctx, addContent };

src/plugins/es_ui_shared/public/components/json_editor/json_editor.tsx

@@ -52,6 +52,8 @@ export const JsonEditor = React.memo(
       isControlled,
     });
 
+    // https://github.com/elastic/kibana/issues/73971
+    /* eslint-disable-next-line react-hooks/exhaustive-deps */
     const debouncedSetContent = useCallback(debounce(setContent, 300), [setContent]);
 
     // We let the consumer control the validation and the error message.
@@ -76,6 +78,7 @@ export const JsonEditor = React.memo(
           debouncedSetContent(updated);
         }
       },
+      /* eslint-disable-next-line react-hooks/exhaustive-deps */
       [isControlled]
     );
 

src/plugins/es_ui_shared/public/components/json_editor/use_json.ts

@@ -84,6 +84,8 @@ export const useJson = <T extends object = { [key: string]: any }>({
     } else {
       didMount.current = true;
     }
+    // https://github.com/elastic/kibana/issues/73971
+    /* eslint-disable-next-line react-hooks/exhaustive-deps */
   }, [content]);
 
   return {

src/plugins/es_ui_shared/public/index.ts

@@ -39,7 +39,7 @@ export {
   UseRequestResponse,
   sendRequest,
   useRequest,
-} from './request/np_ready_request';
+} from './request';
 
 export { indices } from './indices';
 

src/plugins/es_ui_shared/public/request/index.ts

@@ -17,11 +17,5 @@
  * under the License.
  */
 
-export {
-  SendRequestConfig,
-  SendRequestResponse,
-  UseRequestConfig,
-  UseRequestResponse,
-  sendRequest,
-  useRequest,
-} from './request';
+export { SendRequestConfig, SendRequestResponse, sendRequest } from './send_request';
+export { UseRequestConfig, UseRequestResponse, useRequest } from './use_request';