From 08803b625f77e5e4f879c8baaf9d2e499db40a69 Mon Sep 17 00:00:00 2001 From: Nathan Reese Date: Wed, 14 Jun 2017 13:31:39 -0600 Subject: [PATCH] make component stateless --- .../public/terms_vis/components/simple.js | 14 ++++---------- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/src/core_plugins/control_visualizations/public/terms_vis/components/simple.js b/src/core_plugins/control_visualizations/public/terms_vis/components/simple.js index e3a701e369375c..1503456ea049d4 100644 --- a/src/core_plugins/control_visualizations/public/terms_vis/components/simple.js +++ b/src/core_plugins/control_visualizations/public/terms_vis/components/simple.js @@ -5,7 +5,6 @@ export class Simple extends Component { constructor(props) { super(props); - this.state = { params: _.cloneDeep(props.scope.vis.getCurrentState().params) }; @@ -14,14 +13,9 @@ export class Simple extends Component { } handleParam1Change(evt) { - const param1 = evt.target.value; - this.setState((prevState) => { - prevState.params.param1 = param1; - return prevState; - }, - () => { - this.props.stageEditorParams(_.cloneDeep(this.state.params)); - }); + const params = _.cloneDeep(this.props.scope.vis.getCurrentState().params); + params.param1 = evt.target.value; + this.props.stageEditorParams(params); } render() { @@ -37,7 +31,7 @@ export class Simple extends Component {