Skip to content

Commit 085cac1

Browse files
Slim down core bundle (#75912)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
1 parent feab3e3 commit 085cac1

File tree

6 files changed

+17
-8
lines changed

6 files changed

+17
-8
lines changed

src/core/public/chrome/ui/header/collapsible_nav.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ import {
3131
import { i18n } from '@kbn/i18n';
3232
import { groupBy, sortBy } from 'lodash';
3333
import React, { Fragment, useRef } from 'react';
34-
import { useObservable } from 'react-use';
34+
import useObservable from 'react-use/lib/useObservable';
3535
import * as Rx from 'rxjs';
3636
import { ChromeNavLink, ChromeRecentlyAccessedHistoryItem } from '../..';
3737
import { AppCategory } from '../../../../types';

src/core/public/chrome/ui/header/header.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ import {
2828
import { i18n } from '@kbn/i18n';
2929
import classnames from 'classnames';
3030
import React, { createRef, useState } from 'react';
31-
import { useObservable } from 'react-use';
31+
import useObservable from 'react-use/lib/useObservable';
3232
import { Observable } from 'rxjs';
3333
import { LoadingIndicator } from '../';
3434
import {

src/core/public/chrome/ui/header/header_breadcrumbs.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
import { EuiHeaderBreadcrumbs } from '@elastic/eui';
2121
import classNames from 'classnames';
2222
import React from 'react';
23-
import { useObservable } from 'react-use';
23+
import useObservable from 'react-use/lib/useObservable';
2424
import { Observable } from 'rxjs';
2525
import { ChromeBreadcrumb } from '../../chrome_service';
2626

src/core/public/chrome/ui/header/header_logo.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
import { EuiHeaderLogo } from '@elastic/eui';
2121
import { i18n } from '@kbn/i18n';
2222
import React from 'react';
23-
import { useObservable } from 'react-use';
23+
import useObservable from 'react-use/lib/useObservable';
2424
import { Observable } from 'rxjs';
2525
import Url from 'url';
2626
import { ChromeNavLink } from '../..';

src/core/public/chrome/ui/header/header_nav_controls.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919

2020
import { EuiHeaderSectionItem } from '@elastic/eui';
2121
import React from 'react';
22-
import { useObservable } from 'react-use';
22+
import useObservable from 'react-use/lib/useObservable';
2323
import { Observable } from 'rxjs';
2424
import { ChromeNavControl } from '../../nav_controls';
2525
import { HeaderExtension } from './header_extension';

src/core/public/overlays/banners/user_banner_service.tsx

Lines changed: 12 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,12 +19,11 @@
1919

2020
import React, { Fragment } from 'react';
2121
import ReactDOM from 'react-dom';
22-
import ReactMarkdown from 'react-markdown';
2322
import { filter } from 'rxjs/operators';
2423
import { Subscription } from 'rxjs';
2524

2625
import { FormattedMessage } from '@kbn/i18n/react';
27-
import { EuiCallOut, EuiButton } from '@elastic/eui';
26+
import { EuiCallOut, EuiButton, EuiLoadingSpinner } from '@elastic/eui';
2827

2928
import { I18nStart } from '../../i18n';
3029
import { IUiSettingsClient } from '../../ui_settings';
@@ -36,6 +35,8 @@ interface StartDeps {
3635
uiSettings: IUiSettingsClient;
3736
}
3837

38+
const ReactMarkdownLazy = React.lazy(() => import('react-markdown'));
39+
3940
/**
4041
* Sets up the custom banner that can be specified in advanced settings.
4142
* @internal
@@ -75,7 +76,15 @@ export class UserBannerService {
7576
}
7677
iconType="help"
7778
>
78-
<ReactMarkdown renderers={{ root: Fragment }}>{content.trim()}</ReactMarkdown>
79+
<React.Suspense
80+
fallback={
81+
<div>
82+
<EuiLoadingSpinner />
83+
</div>
84+
}
85+
>
86+
<ReactMarkdownLazy renderers={{ root: Fragment }} source={content.trim()} />
87+
</React.Suspense>
7988

8089
<EuiButton type="primary" size="s" onClick={() => banners.remove(id!)}>
8190
<FormattedMessage

0 commit comments

Comments
 (0)