Skip to content

Commit 075fe07

Browse files
committed
extract public uiSettings params in a separate type
1 parent 1036d77 commit 075fe07

File tree

10 files changed

+33
-7
lines changed

10 files changed

+33
-7
lines changed

docs/development/core/server/kibana-plugin-core-server.iuisettingsclient.getregistered.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,5 +9,5 @@ Returns registered uiSettings values [UiSettingsParams](./kibana-plugin-core-ser
99
<b>Signature:</b>
1010

1111
```typescript
12-
getRegistered: () => Readonly<Record<string, Omit<UiSettingsParams, 'schema'>>>;
12+
getRegistered: () => Readonly<Record<string, PublicUiSettingsParams>>;
1313
```

docs/development/core/server/kibana-plugin-core-server.iuisettingsclient.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ export interface IUiSettingsClient
1818
| --- | --- | --- |
1919
| [get](./kibana-plugin-core-server.iuisettingsclient.get.md) | <code>&lt;T = any&gt;(key: string) =&gt; Promise&lt;T&gt;</code> | Retrieves uiSettings values set by the user with fallbacks to default values if not specified. |
2020
| [getAll](./kibana-plugin-core-server.iuisettingsclient.getall.md) | <code>&lt;T = any&gt;() =&gt; Promise&lt;Record&lt;string, T&gt;&gt;</code> | Retrieves a set of all uiSettings values set by the user with fallbacks to default values if not specified. |
21-
| [getRegistered](./kibana-plugin-core-server.iuisettingsclient.getregistered.md) | <code>() =&gt; Readonly&lt;Record&lt;string, Omit&lt;UiSettingsParams, 'schema'&gt;&gt;&gt;</code> | Returns registered uiSettings values [UiSettingsParams](./kibana-plugin-core-server.uisettingsparams.md) |
21+
| [getRegistered](./kibana-plugin-core-server.iuisettingsclient.getregistered.md) | <code>() =&gt; Readonly&lt;Record&lt;string, PublicUiSettingsParams&gt;&gt;</code> | Returns registered uiSettings values [UiSettingsParams](./kibana-plugin-core-server.uisettingsparams.md) |
2222
| [getUserProvided](./kibana-plugin-core-server.iuisettingsclient.getuserprovided.md) | <code>&lt;T = any&gt;() =&gt; Promise&lt;Record&lt;string, UserProvidedValues&lt;T&gt;&gt;&gt;</code> | Retrieves a set of all uiSettings values set by the user. |
2323
| [isOverridden](./kibana-plugin-core-server.iuisettingsclient.isoverridden.md) | <code>(key: string) =&gt; boolean</code> | Shows whether the uiSettings value set by the user. |
2424
| [remove](./kibana-plugin-core-server.iuisettingsclient.remove.md) | <code>(key: string) =&gt; Promise&lt;void&gt;</code> | Removes uiSettings value by key. |

docs/development/core/server/kibana-plugin-core-server.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -231,6 +231,7 @@ The plugin integrates with the core system via lifecycle events: `setup`<!-- -->
231231
| [PluginInitializer](./kibana-plugin-core-server.plugininitializer.md) | The <code>plugin</code> export at the root of a plugin's <code>server</code> directory should conform to this interface. |
232232
| [PluginName](./kibana-plugin-core-server.pluginname.md) | Dedicated type for plugin name/id that is supposed to make Map/Set/Arrays that use it as a key or value more obvious. |
233233
| [PluginOpaqueId](./kibana-plugin-core-server.pluginopaqueid.md) | |
234+
| [PublicUiSettingsParams](./kibana-plugin-core-server.publicuisettingsparams.md) | A sub-set of [UiSettingsParams](./kibana-plugin-core-server.uisettingsparams.md) exposed to the client-side. |
234235
| [RecursiveReadonly](./kibana-plugin-core-server.recursivereadonly.md) | |
235236
| [RedirectResponseOptions](./kibana-plugin-core-server.redirectresponseoptions.md) | HTTP response parameters for redirection response |
236237
| [RequestHandler](./kibana-plugin-core-server.requesthandler.md) | A function executed when route path matched requested resource path. Request handler is expected to return a result of one of [KibanaResponseFactory](./kibana-plugin-core-server.kibanaresponsefactory.md) functions. |
Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,13 @@
1+
<!-- Do not edit this file. It is automatically generated by API Documenter. -->
2+
3+
[Home](./index.md) &gt; [kibana-plugin-core-server](./kibana-plugin-core-server.md) &gt; [PublicUiSettingsParams](./kibana-plugin-core-server.publicuisettingsparams.md)
4+
5+
## PublicUiSettingsParams type
6+
7+
A sub-set of [UiSettingsParams](./kibana-plugin-core-server.uisettingsparams.md) exposed to the client-side.
8+
9+
<b>Signature:</b>
10+
11+
```typescript
12+
export declare type PublicUiSettingsParams = Omit<UiSettingsParams, 'schema'>;
13+
```

src/core/server/index.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -248,6 +248,7 @@ export {
248248
export {
249249
IUiSettingsClient,
250250
UiSettingsParams,
251+
PublicUiSettingsParams,
251252
UiSettingsType,
252253
UiSettingsServiceSetup,
253254
UiSettingsServiceStart,

src/core/server/server.api.md

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -982,7 +982,7 @@ export interface IScopedRenderingClient {
982982
export interface IUiSettingsClient {
983983
get: <T = any>(key: string) => Promise<T>;
984984
getAll: <T = any>() => Promise<Record<string, T>>;
985-
getRegistered: () => Readonly<Record<string, Omit<UiSettingsParams, 'schema'>>>;
985+
getRegistered: () => Readonly<Record<string, PublicUiSettingsParams>>;
986986
getUserProvided: <T = any>() => Promise<Record<string, UserProvidedValues<T>>>;
987987
isOverridden: (key: string) => boolean;
988988
remove: (key: string) => Promise<void>;
@@ -1427,6 +1427,9 @@ export interface PluginsServiceStart {
14271427
contracts: Map<PluginName, unknown>;
14281428
}
14291429

1430+
// @public
1431+
export type PublicUiSettingsParams = Omit<UiSettingsParams, 'schema'>;
1432+
14301433
// Warning: (ae-forgotten-export) The symbol "RecursiveReadonlyArray" needs to be exported by the entry point index.d.ts
14311434
//
14321435
// @public (undocumented)

src/core/server/ui_settings/index.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@ export {
2727
UiSettingsServiceStart,
2828
IUiSettingsClient,
2929
UiSettingsParams,
30+
PublicUiSettingsParams,
3031
InternalUiSettingsServiceSetup,
3132
InternalUiSettingsServiceStart,
3233
UiSettingsType,

src/core/server/ui_settings/types.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,9 +17,10 @@
1717
* under the License.
1818
*/
1919
import { SavedObjectsClientContract } from '../saved_objects/types';
20-
import { UiSettingsParams, UserProvidedValues } from '../../types';
20+
import { UiSettingsParams, UserProvidedValues, PublicUiSettingsParams } from '../../types';
2121
export {
2222
UiSettingsParams,
23+
PublicUiSettingsParams,
2324
StringValidationRegexString,
2425
StringValidationRegex,
2526
StringValidation,
@@ -41,7 +42,7 @@ export interface IUiSettingsClient {
4142
/**
4243
* Returns registered uiSettings values {@link UiSettingsParams}
4344
*/
44-
getRegistered: () => Readonly<Record<string, Omit<UiSettingsParams, 'schema'>>>;
45+
getRegistered: () => Readonly<Record<string, PublicUiSettingsParams>>;
4546
/**
4647
* Retrieves uiSettings values set by the user with fallbacks to default values if not specified.
4748
*/

src/core/server/ui_settings/ui_settings_client.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ import { SavedObjectsErrorHelpers } from '../saved_objects';
2222
import { SavedObjectsClientContract } from '../saved_objects/types';
2323
import { Logger } from '../logging';
2424
import { createOrUpgradeSavedConfig } from './create_or_upgrade_saved_config';
25-
import { IUiSettingsClient, UiSettingsParams } from './types';
25+
import { IUiSettingsClient, UiSettingsParams, PublicUiSettingsParams } from './types';
2626
import { CannotOverrideError } from './ui_settings_errors';
2727

2828
export interface UiSettingsServiceOptions {
@@ -72,7 +72,7 @@ export class UiSettingsClient implements IUiSettingsClient {
7272
}
7373

7474
getRegistered() {
75-
const copiedDefaults: Record<string, Omit<UiSettingsParams, 'schema'>> = {};
75+
const copiedDefaults: Record<string, PublicUiSettingsParams> = {};
7676
for (const [key, value] of Object.entries(this.defaults)) {
7777
copiedDefaults[key] = omit(value, 'schema');
7878
}

src/core/types/ui_settings.ts

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -82,6 +82,12 @@ export interface UiSettingsParams<T = unknown> {
8282
schema?: Type<T>;
8383
}
8484

85+
/**
86+
* A sub-set of {@link UiSettingsParams} exposed to the client-side.
87+
* @public
88+
* */
89+
export type PublicUiSettingsParams = Omit<UiSettingsParams, 'schema'>;
90+
8591
/**
8692
* Allows regex objects or a regex string
8793
* @public

0 commit comments

Comments
 (0)