Skip to content

Conversation

@gpop63
Copy link
Contributor

@gpop63 gpop63 commented Mar 22, 2023

What does this PR do?

Migrates visualizations to lenses and adds input control groups.

Before:
rds_before

After:
rds_after

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@elasticmachine
Copy link

elasticmachine commented Mar 22, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-05-29T00:05:02.846+0000

  • Duration: 54 min 13 sec

Test stats 🧪

Test Results
Failed 0
Passed 188
Skipped 4
Total 192

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Mar 22, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (15/15) 💚
Files 93.75% (15/16) 👎 -3.384
Classes 93.75% (15/16) 👎 -3.384
Methods 86.131% (236/274) 👎 -6.414
Lines 85.925% (7387/8597) 👎 -6.078
Conditionals 100.0% (0/0) 💚

@gpop63 gpop63 added Team:Cloud-Monitoring Label for the Cloud Monitoring team Integration:aws AWS labels Mar 22, 2023
@gpop63 gpop63 marked this pull request as ready for review March 22, 2023 18:46
@gpop63 gpop63 requested review from a team as code owners March 22, 2023 18:46
Copy link
Contributor

@drewdaemon drewdaemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's change those two legacy metrics to Lens metrics and arrange them horizontally instead of vertically.

@botelastic
Copy link

botelastic bot commented May 5, 2023

Hi! We just realized that we haven't looked into this PR in a while. We're sorry! We're labeling this issue as Stale to make it hit our filters and make sure we get back to it as soon as possible. In the meantime, it'd be extremely helpful if you could take a look at it as well and confirm its relevance. A simple comment with a nice emoji will be enough :+1. Thank you for your contribution!

@botelastic botelastic bot added the Stalled label May 5, 2023
@botelastic botelastic bot removed the Stalled label May 15, 2023
@gpop63
Copy link
Contributor Author

gpop63 commented May 15, 2023

Fixed:

aws_rds_metric

@drewdaemon
Copy link
Contributor

Thanks @gpop63 !

Sorry for the whiplash, but I think that in this case maybe the legacy metric makes more sense.

I still like the horizontal configuration of the panels, but we're dealing with so much space that the number is very far away from the label which isn't really how the new metric is supposed to be.

Copy link
Contributor

@drewdaemon drewdaemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving so as not to hold you up

@gpop63 gpop63 self-assigned this May 22, 2023
@gpop63 gpop63 merged commit 4ad2b5d into elastic:main May 29, 2023
@elasticmachine
Copy link

Package aws - 1.37.2 containing this change is available at https://epr.elastic.co/search?package=aws

@rameshelastic rameshelastic mentioned this pull request May 29, 2023
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Integration:aws AWS Team:Cloud-Monitoring Label for the Cloud Monitoring team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants