Skip to content
This repository has been archived by the owner on May 16, 2023. It is now read-only.

[meta] Simplify doc in 7.x branch #860

Merged
merged 2 commits into from
Oct 21, 2020
Merged

Conversation

nkammah
Copy link
Contributor

@nkammah nkammah commented Oct 21, 2020

Reword warning statements in chart readme to streamline the release process - related PR : #858, #859

@nkammah nkammah requested a review from jmlrt October 21, 2020 12:05
@nkammah nkammah changed the title Streamline charts README doc [all] Simplify doc in 7.x branch Oct 21, 2020
Copy link
Member

@jmlrt jmlrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM⛴ but some comments to simplify even more doc updates during releases

@@ -8,8 +8,8 @@ The design and code is less mature than official GA features and is being
provided as-is with no warranties. Alpha features are not subject to the support
SLA of official GA features (see [supported configurations][] for more details).

**Warning**: This branch is used for development, please use [7.7.1][] release
for released version.
**Warning**: This branch is used for development, please use the latest [7.10](https://github.com/elastic/helm-charts/releases)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

7.10 isn't released yet so this is not accurate. Also this would require us to update it each time we would release a new minor version (7.11, ...) to stay up to date.

Maybe we could just mention the latest 7.x release

Copy link
Member

@jmlrt jmlrt Oct 21, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same comment as #859 (comment) about having the warning statement in a single line

@jmlrt
Copy link
Member

jmlrt commented Oct 21, 2020

jenkins test this please

@nkammah nkammah merged commit 5d351fb into elastic:7.x Oct 21, 2020
@nkammah nkammah deleted the streamline-doc-7x branch October 21, 2020 15:53
This was referenced Nov 17, 2020
@jmlrt jmlrt mentioned this pull request Nov 23, 2020
@jmlrt jmlrt changed the title [all] Simplify doc in 7.x branch [meta] Simplify doc in 7.x branch Nov 23, 2020
@jmlrt jmlrt mentioned this pull request Feb 8, 2021
This was referenced Mar 15, 2021
@jmlrt jmlrt mentioned this pull request May 25, 2021
@jmlrt jmlrt mentioned this pull request Mar 8, 2022
@jmlrt jmlrt mentioned this pull request Apr 21, 2022
This was referenced Sep 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants