-
Notifications
You must be signed in to change notification settings - Fork 1.9k
[all] Simplify doc in 7.9 branch #859
[all] Simplify doc in 7.9 branch #859
Conversation
45f8f9e
to
eef9409
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM⛴ just one comment to make release automation easier
apm-server/README.md
Outdated
**Warning**: This branch is used for development, please use the latest [7.9](https://github.com/elastic/helm-charts/releases) | ||
release for released version. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe keeping this statement in a single line would make easier to automate removing it during release and adding it back after releases
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The intent with that PR is that we will not add/remove that warning statement for / after the release. Do you foresee this being an issue?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes this is an issue because this statement will be displayed in Artifact Hub and will make user think that released charts are for development.
apm-server/README.md
Outdated
@@ -8,8 +8,8 @@ The design and code is less mature than official GA features and is being | |||
provided as-is with no warranties. Alpha features are not subject to the support | |||
SLA of official GA features (see [supported configurations][] for more details). | |||
|
|||
**Warning**: This branch is used for development, please use [7.9.2][https://github.com/elastic/helm-charts/releases/tag/7.9.2] release for released version. | |||
|
|||
**Warning**: This branch is used for development, please use the latest [7.9](https://github.com/elastic/helm-charts/releases) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another comment, maybe we could mention 7.x instead 7.9 see #860 (comment)
Reword warning statements in chart readme to streamline the release process - related PR : #858