This repository has been archived by the owner on May 16, 2023. It is now read-only.
Filebeat improvements #568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdelapenya
previously approved these changes
Apr 8, 2020
There was a problem hiding this comment.
LGTM, I'd like @ChrsMark to also review it, as his team is the stakeholder of the Helm chart reference
ChrsMark
reviewed
Apr 9, 2020
| - '*' | ||
| - type: container | ||
| paths: | ||
| - /var/log/containers/*.log |
There was a problem hiding this comment.
Just to be sure, is this path actually where hosts' var/log is mounted? This is what I expect to see https://github.com/elastic/beats/blob/1a029e547fb1018668e7ab961bcbbe496696ff25/deploy/kubernetes/filebeat-kubernetes.yaml#L110.
There was a problem hiding this comment.
Thanks for the notice, fixed by 72f704e
[filebeat] mount /var/log inside filebeat pods This is required to use container input withg CRI paths.
|
jenkins test this please |
|
jenkins test this please |
1 similar comment
|
jenkins test this please |
mgreau
reviewed
Apr 10, 2020
filebeat/examples/6.x/values.yaml
Outdated
| in_cluster: true | ||
| output.elasticsearch: | ||
| host: '${NODE_NAME}' | ||
| hosts: '${ELASTICSEARCH_HOSTS:elasticsearch-master:9200}' |
container input doesn't exist on 6.8 and in_cluster is still documented
jmlrt
force-pushed
the
filebeat-improvements
branch
from
81ffe66
to
d5c048b
Compare
4 tasks
Closed
Closed
This was referenced Nov 17, 2020
Closed
Closed
Closed
Closed
Closed
This was referenced Dec 14, 2021
Merged
Merged
Merged
This was referenced Sep 14, 2022
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in_clusterconfig from `add_kubernetes_metadatacontainerinput instead ofdockerinputadd_kubernetes_metadataFixes #558
README.md updated with any new values or changesUpdated template tests in${CHART}/tests/*.py${CHART}/examples/*/test/goss.yaml