Make kube-state-metrics optional for installation #387

SergK · 2019-11-27T20:25:49Z

In the most cases kube-state-metrics is already installed on the
cluster, so let's just re-use it, instead of installing another
one copy. By default, kube-state-metrics are installed as dependency,
so this PR doesn't change the default behaviour

Signed-off-by: Sergiy Kulanov sergey@kulanov.org.ua

[*] Chart version not bumped (the versions are all bumped and released at the same time)
[*] README.md updated with any new values or changes
[*] Updated template tests in ${CHART}/tests/*.py
Updated integration tests in ${CHART}/examples/*/test/goss.yaml

elasticmachine · 2019-11-27T20:25:50Z

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

jmlrt · 2019-12-18T13:15:07Z

jenkins test this please

pbecotte · 2020-01-17T12:16:04Z

metricbeat/templates/deployment.yaml

@@ -92,7 +92,11 @@ spec:
            fieldRef:
              fieldPath: metadata.namespace
        - name: KUBE_STATE_METRICS_HOSTS
+          {{- if .Values.kube_state_metrics.enabled }}
          value: "$({{ .Release.Name | replace "-" "_" | upper }}_KUBE_STATE_METRICS_SERVICE_HOST):$({{ .Release.Name | replace "-" "_" | upper }}_KUBE_STATE_METRICS_SERVICE_PORT_HTTP)"


Would it make more sense here to just use the kube_state_metrics_host value even if we are installing the sub-chart? In that case, what is the value that gets passed to the subchart as the service name?

Hi @pbecotte . The general idea is to preserve upstream behavior as much as possible,
so when user disables kube_state_metrics installation then he/she needs to provide
existing endpoint for kube_state_metrics

botelastic · 2020-04-16T12:20:59Z

This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. To track this PR (even if closed), please open a corresponding issue if one does not already exist.

erihanse · 2020-07-08T13:42:14Z

Is there something needed to get progress on this feature?

jmlrt · 2020-07-08T16:00:14Z

Hi @erihanse

Is there something needed to get progress on this feature?

The first thing is to have time for a proper review, tests and impacts analysis. This one is pretty old and important, it is in the top of the backlog and we should be able to review it soon.

@SergK, I'm sorry for the delay, Metricbeat had a lot of changes since you created this PR. Can you merge master on your branch and fix the conflicts?

SergK · 2020-07-10T09:42:42Z

@jmlrt done!

jmlrt · 2020-07-13T08:41:47Z

jenkins test this please

jmlrt · 2020-07-13T09:19:42Z

Some changes are required to make Black formatter happy in elastic+helm-charts+pull-request+lint-python/361.

Can you run black tests/metricbeat_test.py and update your PR?

SergK · 2020-07-13T09:28:44Z

Sure!

jmlrt · 2020-07-13T09:42:21Z

jenkins test this please

jmlrt

My tests are OK, I have a last small request to replace kube_state_metrics_host by kube_state_metrics.hostso we can have nested values like that:

kube_state_metrics:
  enabled: true
  # is used only when kube_state_metrics.enabled: false
  host: ""

instead of:

# is used only when kube_state_metrics.enabled: false
kube_state_metrics_host: ""

kube_state_metrics:
  enabled: true

metricbeat/values.yaml

In the most cases kube-state-metrics is already installed on the cluster, so let's just re-use it, instead of installing another one copy. By default, kube-state-metrics are installed as dependency, so this PR doesn't change the default behaviour Signed-off-by: Sergiy Kulanov <sergey@kulanov.org.ua>

jmlrt · 2020-07-13T12:05:12Z

jenkins test this please

jmlrt

LGTM⛴

In the most cases kube-state-metrics is already installed on the cluster, so let's just re-use it, instead of installing another one copy. By default, kube-state-metrics are installed as dependency, so this PR doesn't change the default behaviour Signed-off-by: Sergiy Kulanov <sergey@kulanov.org.ua>

jmlrt · 2020-07-13T13:55:51Z

backported to 6.8, 7.8and 7.x branches

pbecotte reviewed Jan 17, 2020

View reviewed changes

jmlrt added the enhancement New feature or request label Jan 20, 2020

jmlrt mentioned this pull request Apr 6, 2020

Giving more control on the kubeStateMetrics subchart for Metricbeat #561

Closed

2 tasks

botelastic bot added the triage/stale label Apr 16, 2020

SergK closed this Apr 16, 2020

SergK reopened this Apr 16, 2020

botelastic bot removed the triage/stale label Apr 16, 2020

jmlrt mentioned this pull request Apr 17, 2020

metricbeat without kube-state-metrics #574

Closed

jmlrt suggested changes Jul 13, 2020

View reviewed changes

metricbeat/values.yaml Outdated Show resolved Hide resolved

jmlrt approved these changes Jul 13, 2020

View reviewed changes

jmlrt added metricbeat v6.8.11 v7.8.1 labels Jul 13, 2020

jmlrt merged commit 01ed638 into elastic:master Jul 13, 2020

erihanse mentioned this pull request Jul 14, 2020

Metricbeat daemonset deployment optional #716

Merged

4 tasks

This was referenced Jul 16, 2020

7.8.1 Release #730

Closed

6.8.11 Release #731

Closed

This was referenced Jul 27, 2020

6.8.11 Release #753

Merged

7.8.1 Release #754

Merged

jmlrt mentioned this pull request Oct 28, 2020

fix 854 68 #876

Closed

This was referenced Nov 17, 2020

68 helm 3 #900

Closed

7x helm 3 #901

Closed

68 helm 3 #903

Closed

7.10 init #913

Closed

710 readme enhancements #926

Closed

jmlrt mentioned this pull request Feb 8, 2021

backport 1046 7x #1051

Closed

This was referenced Mar 15, 2021

7.12 #1101

Closed

7.x #1113

Closed

jmlrt mentioned this pull request May 25, 2021

7.x bump #1199

Closed

This was referenced Dec 14, 2021

[meta] initiate 7.16 branch #1475

Merged

[kibana] optionally disable SA token automount (#1301) #1481

Merged

6.8.21 bump #1488

Merged

jmlrt mentioned this pull request Mar 8, 2022

7.17.1 bump #1609

Merged

jmlrt mentioned this pull request Apr 21, 2022

7.17.3 bump #1649

Merged

This was referenced Sep 14, 2022

[meta] fix yaml indent #1698

Merged

[meta] follow-up of #1698 #1700

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Make kube-state-metrics optional for installation #387

Make kube-state-metrics optional for installation #387

SergK commented Nov 27, 2019

elasticmachine commented Nov 27, 2019

jmlrt commented Dec 18, 2019

pbecotte Jan 17, 2020

SergK Apr 16, 2020

botelastic bot commented Apr 16, 2020

erihanse commented Jul 8, 2020

jmlrt commented Jul 8, 2020

SergK commented Jul 10, 2020

jmlrt commented Jul 13, 2020

jmlrt commented Jul 13, 2020

SergK commented Jul 13, 2020

jmlrt commented Jul 13, 2020

jmlrt left a comment

jmlrt commented Jul 13, 2020

jmlrt left a comment

jmlrt commented Jul 13, 2020

Make kube-state-metrics optional for installation #387

Make kube-state-metrics optional for installation #387

Conversation

SergK commented Nov 27, 2019

elasticmachine commented Nov 27, 2019

jmlrt commented Dec 18, 2019

pbecotte Jan 17, 2020

Choose a reason for hiding this comment

SergK Apr 16, 2020

Choose a reason for hiding this comment

botelastic bot commented Apr 16, 2020

erihanse commented Jul 8, 2020

jmlrt commented Jul 8, 2020

SergK commented Jul 10, 2020

jmlrt commented Jul 13, 2020

jmlrt commented Jul 13, 2020

SergK commented Jul 13, 2020

jmlrt commented Jul 13, 2020

jmlrt left a comment

Choose a reason for hiding this comment

jmlrt commented Jul 13, 2020

jmlrt left a comment

Choose a reason for hiding this comment

jmlrt commented Jul 13, 2020