Skip to content
This repository has been archived by the owner on May 16, 2023. It is now read-only.

Point statefulset to the right serviceaccount #1497

Closed
wants to merge 1 commit into from

Conversation

mdnfiras
Copy link

@mdnfiras mdnfiras commented Dec 15, 2021

  • Chart version not bumped (the versions are all bumped and released at the same time)
  • README.md updated with any new values or changes
  • Updated template tests in ${CHART}/tests/*.py
  • Updated integration tests in ${CHART}/examples/*/test/goss.yaml

@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@mdnfiras
Copy link
Author

@ebuildy moved here from #1456 in order to merge with 7.16.0
this PR is for fixing this issue: #1455

@ebuildy
Copy link
Contributor

ebuildy commented Dec 18, 2021

I just saw: https://github.com/elastic/helm-charts/blob/main/apm-server/templates/_helpers.tpl#L22 a better way to achieve this.

You could copy this for elasticsearch chart as well.

@jmlrt
Copy link
Member

jmlrt commented Feb 23, 2022

Hi, @mdnfiras thanks for this PR. I created #1580 which will fix and improve we are are already doing in APM, Filebeat and Metricbeat charts.

@jmlrt jmlrt closed this Feb 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants