This repository has been archived by the owner on May 16, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit bump the Helm version used in helm-charts tests to 3.6.0. https://github.com/helm/helm/releases/tag/v3.6.0
jenkins test this please |
Conky5
previously approved these changes
May 28, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Conky5
approved these changes
Jul 7, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
jmlrt
added a commit
to jmlrt/helm-charts
that referenced
this pull request
Sep 13, 2021
* [meta] add helm 3.6.0 support This commit bump the Helm version used in helm-charts tests to 3.6.0. https://github.com/helm/helm/releases/tag/v3.6.0 * [meta] bump to helm 3.6.2 * [meta] add retry to goss test
jmlrt
added a commit
to jmlrt/helm-charts
that referenced
this pull request
Sep 13, 2021
* [meta] add helm 3.6.0 support This commit bump the Helm version used in helm-charts tests to 3.6.0. https://github.com/helm/helm/releases/tag/v3.6.0 * [meta] bump to helm 3.6.2 * [meta] add retry to goss test
jmlrt
added a commit
to jmlrt/helm-charts
that referenced
this pull request
Sep 13, 2021
* [meta] add helm 3.6.0 support This commit bump the Helm version used in helm-charts tests to 3.6.0. https://github.com/helm/helm/releases/tag/v3.6.0 * [meta] bump to helm 3.6.2 * [meta] add retry to goss test
jmlrt
added a commit
that referenced
this pull request
Sep 21, 2021
* [meta] add helm 3.6.0 support This commit bump the Helm version used in helm-charts tests to 3.6.0. https://github.com/helm/helm/releases/tag/v3.6.0 * [meta] bump to helm 3.6.2 * [meta] add retry to goss test
jmlrt
added a commit
that referenced
this pull request
Sep 21, 2021
* [meta] add helm 3.6.0 support This commit bump the Helm version used in helm-charts tests to 3.6.0. https://github.com/helm/helm/releases/tag/v3.6.0 * [meta] bump to helm 3.6.2 * [meta] add retry to goss test
jmlrt
added a commit
that referenced
this pull request
Sep 21, 2021
* [meta] add helm 3.6.0 support This commit bump the Helm version used in helm-charts tests to 3.6.0. https://github.com/helm/helm/releases/tag/v3.6.0 * [meta] bump to helm 3.6.2 * [meta] add retry to goss test
This was referenced Dec 14, 2021
Merged
Merged
Merged
This was referenced Sep 14, 2022
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit bumps the Helm version used in helm-charts tests to 3.6.2.
https://github.com/helm/helm/releases/tag/v3.6.2
Also, add retries to goss test to avoid
filespec must match the canonical format: [[namespace/]pod:]file/path
error if pods are slower to start (example).