This repository has been archived by the owner on May 16, 2023. It is now read-only.
[apm-server] Add option loadBalancerIP to service #1075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
ebuildy
changed the title
|
jenkins test this please |
jmlrt
suggested changes
Feb 24, 2021
There was a problem hiding this comment.
Some changes are required to make Black formatter happy in https://devops-ci.elastic.co/job/elastic+helm-charts+pull-request+lint-python/828/label=docker&&virtual&&ubuntu-18.04/console.
Can you run black <CHART>/tests/<CHART>_test.py?
|
jenkins test this please |
|
I think this will also need to be rebased on master to make tests pass. |
Signed-off-by: ebuildy <ebuildy@gmail.com>
|
jenkins test this please |
jmlrt
pushed a commit
to jmlrt/helm-charts
that referenced
this pull request
Mar 9, 2021
jmlrt
pushed a commit
to jmlrt/helm-charts
that referenced
this pull request
Mar 9, 2021
jmlrt
added a commit
that referenced
this pull request
Mar 9, 2021
jmlrt
added a commit
that referenced
this pull request
Mar 9, 2021
This was referenced Mar 23, 2021
Closed
This was referenced Dec 14, 2021
Merged
Merged
Merged
This was referenced Sep 14, 2022
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
${CHART}/tests/*.py${CHART}/examples/*/test/goss.yamlSee #1031 - this PR add "service.loadBalancerIP" field. (copied from Kibana chart).