[EuiCallOut] Support popover and tooltip on actionProps#9705
Open
mgadewoll wants to merge 13 commits into
Open
[EuiCallOut] Support popover and tooltip on actionProps#9705mgadewoll wants to merge 13 commits into
mgadewoll wants to merge 13 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds support for wrapping EuiCallOut actionProps actions with EuiPopover and/or EuiToolTip, enabling consumers to attach popovers/tooltips to the new stricter action object shape.
Changes:
- Added
popoverPropsandtooltipPropstoEuiCallOutprimary/secondary action prop types and render logic. - Introduced
withEuiPopover/withEuiToolTipwrapper utilities and exported them from their component barrels. - Added unit tests and Storybook stories covering tooltip/popover callout actions.
Reviewed changes
Copilot reviewed 8 out of 12 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/eui/src/components/tool_tip/with_tooltip.tsx | Adds a small helper to wrap a React element in EuiToolTip when props are provided. |
| packages/eui/src/components/tool_tip/index.ts | Exports the new tooltip wrapper helper/type. |
| packages/eui/src/components/popover/with_popover.tsx | Adds a small helper to wrap a React element in EuiPopover when props are provided. |
| packages/eui/src/components/popover/index.ts | Exports the new popover wrapper helper/type. |
| packages/eui/src/components/call_out/call_out_action.tsx | Extends action props to accept tooltip/popover props and composes wrappers around action buttons. |
| packages/eui/src/components/call_out/call_out.styles.ts | Updates layout/styling for actions (notably super-narrow full-width behavior). |
| packages/eui/src/components/call_out/call_out.test.tsx | Adds tests for tooltip/popover rendering on actions. |
| packages/eui/src/components/call_out/call_out.stories.tsx | Adds Storybook stories (and Loki portal selector) for tooltip/popover action variants. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
59395d4 to
0e3e43d
Compare
acstll
approved these changes
Jun 5, 2026
acstll
left a comment
Contributor
There was a problem hiding this comment.
🟢 Working as expected, went through QA instructions. Only left a comment regarding the changelog.
Collaborator
💚 Build Succeeded
History
cc @mgadewoll |
Collaborator
💚 Build SucceededHistory
cc @mgadewoll |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates
EuiCallOut, specifically adding support forpopoverPropsandtooltipPropson the recently addedactionPropsAPI.Because the API was made stricter using an object shape to strictly define actions, it's not possible to compose actions and popovers on consumer side anymore. Instead we'll need to support it internally via the same prop shape.
This PR adds higher-order utils
withEuiPopoverandwithEuiToolTipto centralize rendering a wrapped action.Note
We might be able to resolve this gain once we refactor EuiPopover/EuiToolTip to not require passing the trigger element as prop.
Additional changes
API Changes
actionPropspopoverPropsandtooltipPropsfor each action.Screenshots
popoverPropstooltipPropsImpact Assessment
Note: Most PRs should be tested in Kibana to help gauge their Impact before merging.
Impact level: 🟢 None
This is a new feature. Implementations will first need to be migrated to use this.
Release Readiness
QA instructions for reviewer
💻 popoverProps
💻 tooltipProps
popoverPropsapplies correctly and renders a popover on callout actionstooltipPropsapplies correctly and renders a tooltip on callout actionspopoverPropsandtooltipPropscombined both apply correctly and renders a popover and tooltip on callout actionsChecklist before marking Ready for Review
QA: Tested in CodeSandbox and [Kibana](https://github.com/elastic/eui/blob/main/wiki/contributing-to-eui/testing/testing-in-kibana.md)QA: Tested docs changesBreaking changes: Addedbreaking changelabel (if applicable)Reviewer checklist