-
Notifications
You must be signed in to change notification settings - Fork 841
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Emotion] Convert EuiDataGrid toolbar control styles to Emotion (Part 2) #7997
Merged
Merged
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
09e19f8
Convert controls toolbar styles
cee-chen 8bd364b
Handle grid borders style
cee-chen c5493fa
[microperf] Make control button Emotion styles static
cee-chen d51373b
Delete `.euiDataGrid__controlScroll` CSS + Sass variable
cee-chen 1bb2543
Convert column selector control to Emotion
cee-chen 19633da
Convert sorting control to Emotion
cee-chen 0bdf395
Convert keyboard shortcuts to Emotion
cee-chen 2e3b8d3
Convert display selector width style
cee-chen 6036bc1
Delete Sass files
cee-chen 115c9f2
changelog
cee-chen 052965f
Add stories + VRT for datagrid toolbar
cee-chen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,11 +0,0 @@ | ||
| .euiDataGrid__keyboardShortcuts { | ||
| display: block; | ||
| max-inline-size: $euiSizeXXL * 10; | ||
| max-block-size: 80vh; | ||
| overflow-y: auto; | ||
| overflow-block: auto; | ||
|
|
||
| .euiDescriptionList { | ||
| row-gap: 0; // Row spacing handled by default EuiText dd/dt styles | ||
| } | ||
| } | ||
34 changes: 34 additions & 0 deletions
34
packages/eui/src/components/datagrid/controls/keyboard_shortcuts.styles.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| /* | ||
| * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
| * or more contributor license agreements. Licensed under the Elastic License | ||
| * 2.0 and the Server Side Public License, v 1; you may not use this file except | ||
| * in compliance with, at your election, the Elastic License 2.0 or the Server | ||
| * Side Public License, v 1. | ||
| */ | ||
|
|
||
| import { css } from '@emotion/react'; | ||
|
|
||
| import { UseEuiTheme } from '../../../services'; | ||
| import { euiYScroll, logicalCSS, mathWithUnits } from '../../../global_styling'; | ||
|
|
||
| export const euiDataGridKeyboardShortcutsStyles = ( | ||
| euiThemeContext: UseEuiTheme | ||
| ) => { | ||
| const { euiTheme } = euiThemeContext; | ||
|
|
||
| return { | ||
| euiDataGrid__keyboardShortcuts: css` | ||
| ${logicalCSS('max-height', '80vh')} | ||
| ${logicalCSS( | ||
| 'max-width', | ||
| mathWithUnits(euiTheme.size.xxl, (x) => x * 10) | ||
| )} | ||
| padding: ${euiTheme.size.m}; | ||
| ${euiYScroll(euiThemeContext)} | ||
|
|
||
| .euiDescriptionList { | ||
| row-gap: 0; /* Row spacing handled by default EuiText dd/dt styles */ | ||
| } | ||
| `, | ||
| }; | ||
| }; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change of padding placement caused a slight visual regression but I think it's a) a correct change and b) not a big visual impact.
Screen.Recording.2024-09-05.at.09.36.42.mov
Screen.Recording.2024-09-05.at.09.38.04.mov
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, it's an intentional change! 🎉 Thanks as always for your eagle eyes Lene!