Chunked encoding for _cat APIs #92022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some of these APIs scale as O(#indices) or O(#shards) so it seems worthwhile to use chunked encoding throughout. Relates elastic#89838
DaveCTurner
added
>non-issue
:Distributed/Network
|
Pinging @elastic/es-distributed (Team:Distributed) |
DaveCTurner
commented
Nov 30, 2022
| import java.io.OutputStream; | ||
| import java.io.Writer; | ||
|
|
||
| public final class UTF8StreamWriter extends Writer { |
There was a problem hiding this comment.
This claims performance benefits over the JDK's Writer. It's possible those claims are true, but I don't think this is on a hot enough path to warrant having yet another custom (and wholly untested) implementation of UTF-8 encoding, so I've replaced it with a regular Writer instead.
| currentOutput = null; | ||
| return new ReleasableBytesReference(chunkOutput.bytes(), () -> Releasables.closeExpectNoException(chunkOutput)); | ||
| } finally { | ||
| if (currentOutput != null) { |
There was a problem hiding this comment.
Although I don't see any obvious ways to throw exceptions in this area, I'm somewhat dubious about how such an exception would be handled in the networking code (edit: I get it now, but for the sake of safety we have to close currentOutput if we're not returning)
19 tasks
|
@elasticmachine update branch |
test/framework/src/main/java/org/elasticsearch/rest/RestResponseUtils.java
Outdated
Show resolved
Hide resolved
DaveCTurner
added
the
auto-merge-without-approval
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of these APIs scale as O(#indices) or O(#shards) so it seems worthwhile to use chunked encoding throughout.
Relates #89838