-
Notifications
You must be signed in to change notification settings - Fork 25.3k
support arm for shibboleth-idp #89674
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
||
task buildShibbolethImage(type: Exec) { | ||
workingDir "shibboleth-idp" | ||
commandLine 'docker', 'buildx', 'build', '-t', 'elastic/shibboleth-idp:test', '.', '--platform', 'linux/amd64' //change to linux/arm64v8 to test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
change here to test arm
This worked for me after a changed a couple of things:
I think we don't actually have to worry about (1). Passing |
Thanks Mark ! These pointers make sense and will work on adopting these. |
superseded by: #91216 |
We currently use unicon/shibboleth-idp:3.4.2 to help test our SAML integration. That container is no longer actively supported and does not support ARM architectures. This commit is a partial clone from Unicon/shibboleth-idp-dockerized 3.4.3. Changes from upstream include: Use openjdk:11.0.16-jre as the base image for support for ARM architectures Handle missing keystore download from Jetty Fix URL paths for artifacts to download Changes to this repository include: Copied required Jetty configuration files from upstream project Updates to docker compose Placed the missing keystore Jetty downloads in a separate location (jetty-custom) The final result is a bit messy. Mixing cloned files with custom files and mixing Jetty and IDP concerns. However, it is not much messier than prior and now that we control building the image we can more easily upgrade shibboleth IDP The upgrade to the latest version is fairly involved and as such we will need to deviate more from the clone which should allow some additional clean up. part of: #71378 related: #91144 supersedes: #89674
We currently use unicon/shibboleth-idp:3.4.2 to help test our SAML integration. That container is no longer actively supported and does not support ARM architectures. This commit is a partial clone from Unicon/shibboleth-idp-dockerized 3.4.3. Changes from upstream include: Use openjdk:11.0.16-jre as the base image for support for ARM architectures Handle missing keystore download from Jetty Fix URL paths for artifacts to download Changes to this repository include: Copied required Jetty configuration files from upstream project Updates to docker compose Placed the missing keystore Jetty downloads in a separate location (jetty-custom) The final result is a bit messy. Mixing cloned files with custom files and mixing Jetty and IDP concerns. However, it is not much messier than prior and now that we control building the image we can more easily upgrade shibboleth IDP The upgrade to the latest version is fairly involved and as such we will need to deviate more from the clone which should allow some additional clean up. part of: elastic#71378 related: elastic#91144 supersedes: elastic#89674
We currently use unicon/shibboleth-idp:3.4.2 to help test our SAML integration. That container is no longer actively supported and does not support ARM architectures. This commit is a partial clone from Unicon/shibboleth-idp-dockerized 3.4.3. Changes from upstream include: Use openjdk:11.0.16-jre as the base image for support for ARM architectures Handle missing keystore download from Jetty Fix URL paths for artifacts to download Changes to this repository include: Copied required Jetty configuration files from upstream project Updates to docker compose Placed the missing keystore Jetty downloads in a separate location (jetty-custom) The final result is a bit messy. Mixing cloned files with custom files and mixing Jetty and IDP concerns. However, it is not much messier than prior and now that we control building the image we can more easily upgrade shibboleth IDP The upgrade to the latest version is fairly involved and as such we will need to deviate more from the clone which should allow some additional clean up. part of: #71378 related: #91144 supersedes: #89674
Work in progress.
diff from fork: jakelandis/shibboleth-idp-dockerized@7f8b92b...master
To test on arm device
Note - I think we have some outstanding clean up issues with these running containers, so it might fail if not starting from a clean slate. Just run again (or manually clean up the running docker instances).
Also note ... building from a linux base image instead of the upstream image i forked since we will eventually want to update/upgrade and the upstream image appears to no longer be getting updates.