Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix a typo in Security.java #89248

Merged
merged 4 commits into from
Aug 17, 2022
Merged

fix a typo in Security.java #89248

merged 4 commits into from
Aug 17, 2022

Conversation

dh-cloud
Copy link
Contributor

"path.conf'" has an extra “'”

"path.conf'" has an extra “'”
@cla-checker-service
Copy link

cla-checker-service bot commented Aug 10, 2022

💚 CLA has been signed

@elasticsearchmachine elasticsearchmachine added v8.5.0 needs:triage Requires assignment of a team area label external-contributor Pull request authored by a developer outside the Elasticsearch team labels Aug 10, 2022
@dh-cloud dh-cloud closed this Aug 13, 2022
@dh-cloud dh-cloud reopened this Aug 13, 2022
fix "path.conf'" typo in Security.java
@romseygeek romseygeek added :Core/Infra/Node Lifecycle Node startup, bootstrapping, and shutdown and removed needs:triage Requires assignment of a team area label labels Aug 16, 2022
@elasticsearchmachine elasticsearchmachine added the Team:Core/Infra Meta label for core/infra team label Aug 16, 2022
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

@grcevski grcevski self-assigned this Aug 16, 2022
@grcevski grcevski added the >bug label Aug 16, 2022
@grcevski
Copy link
Contributor

@elasticsearchmachine test this please

Copy link
Contributor

@grcevski grcevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for fixing this.

@@ -0,0 +1,6 @@
pr: 89248
summary: fix "path.conf'" typo in Security.java
area: Bootstrap
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should change the area to one of the known areas. I think it should be Engine.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your opinion,I have modified it.

Fix "path.conf'" typo
@grcevski
Copy link
Contributor

@elasticsearchmachine test this please

@grcevski grcevski merged commit f31b1f6 into elastic:main Aug 17, 2022
@grcevski
Copy link
Contributor

Thanks for your contribution @dh-cloud!

weizijun added a commit to weizijun/elasticsearch that referenced this pull request Aug 19, 2022
* upstream/main: (265 commits)
  Disable openid connect tests due to missing fixture (elastic#89478)
  Add periodic job for single processor node testing
  Updates to changelog processing after docs redesign (elastic#89463)
  Better support for multi cluster for run task (elastic#89442)
  Mute failing tests (elastic#89465)
  [ML] Performance improvements related to ECS Grok pattern usage (elastic#89424)
  Add source fallback support for date and date_nanos mapped types (elastic#89440)
  Reuse Info in lifecycle step (elastic#89419)
  feature: support metrics for multi value fields (elastic#88818)
  Upgrade OpenTelemetry API and remove workaround (elastic#89438)
  Remove LegacyClusterTaskResultActionListener (elastic#89459)
  Add YAML spec docs about matching errors (elastic#89370)
  Remove redundant cluster upgrade tests for auth tokens (elastic#89417)
  Return 400 error for GetUserPrivileges call with API keys (elastic#89333)
  User Profile - Detailed errors in hasPrivileges response (elastic#89224)
  Rollover min_* conditions docs and highlight (elastic#89434)
  REST tests for percentiles_bucket agg (elastic#88029)
  REST tests for cumulative pipeline aggs (elastic#88966)
  Clean-up file watcher keys. (elastic#89429)
  fix a typo in Security.java (elastic#89248)
  ...

# Conflicts:
#	server/src/main/java/org/elasticsearch/index/mapper/NumberFieldMapper.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>bug :Core/Infra/Node Lifecycle Node startup, bootstrapping, and shutdown external-contributor Pull request authored by a developer outside the Elasticsearch team Team:Core/Infra Meta label for core/infra team v8.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants