Improve console exception messages #87942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit improves upon the recent console exception logging isolation to emit more than just the exception message. The exception class is also printed, as well as up to the first 5 elements of the stack. THe stack trace is a hint, and can often be enough, yet the full stack trace (or a truncated version if a guice exception) will still exist in the logs. Addtionally, unit tests are added.
rjernst
added
>enhancement
:Core/Infra/Core
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
|
Hi @rjernst, I've created a changelog YAML for you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit improves upon the recent console exception logging isolation
to emit more than just the exception message. The exception class is
also printed, as well as up to the first 5 elements of the stack. THe
stack trace is a hint, and can often be enough, yet the full stack trace
(or a truncated version if a guice exception) will still exist in the
logs. Addtionally, unit tests are added.