REST tests for avg/max/min/sum_bucket aggs #87009
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nik9000
added
>test
elasticmachine
added
the
Team:Analytics
|
Pinging @elastic/es-analytics-geo (Team:Analytics) |
69 tasks
|
Pinging @elastic/clients-team (Team:Clients) |
Adds REST layer tests for the `avg_bucket`, `max_bucket`, `min_bucket`, and `sum_bucket` pipeline aggregations. This gives us forwards and backwards compatibility tests for these aggs as well as mixed version cluster tests for these aggs. Relates to elastic#26220
csoulios
approved these changes
Jun 9, 2022
There was a problem hiding this comment.
LGTM
I think tests cover the happy path and I wonder if we should test edge or failing cases, such as:
- The path defined
buckets_pathdoes not exist - Dealing with dots in bucket names
- bucket agg returns no results (eg we use a query to filter docs)
On the other hand, testing the happy path is much better than what we had. We can add more tests to cover edge cases with another PR.
| body: | ||
| size: 0 | ||
| aggs: | ||
| "@timestamp": |
There was a problem hiding this comment.
In the old times, the most used bucket aggregation was the terms agg. Now is the time series era :) 👍
Yeah. That'd be good too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds REST layer tests for the
avg_bucket,max_bucket,min_bucket,and
sum_bucketpipeline aggregations. This gives us forwards andbackwards compatibility tests for these aggs as well as mixed version
cluster tests for these aggs.
Relates to #26220