Template disallow changing index_mode from time_series to something else #84116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… else if a tsdb data stream still matches with that template
martijnvg
added
>non-issue
:Data Management/Data streams
elasticmachine
added
the
Team:Data Management
|
Pinging @elastic/es-data-management (Team:Data Management) |
dakrone
approved these changes
Feb 17, 2022
| @@ -734,6 +736,53 @@ private static void validateDataStreamsStillReferenced(ClusterState state, Strin | |||
| } | |||
| } | |||
|
|
|||
| // This method should be invoked after validateDataStreamsStillReferenced(...) | |||
There was a problem hiding this comment.
Is the reason why it should be invoked after because we want to check the more generic case first before the more specific TSDB case?
There was a problem hiding this comment.
Yes, currently this is mainly because it assumes that templates that do match with existing data streams have a DataStreamTemplate, which is something that validateDataStreamsStillReferenced(...) is checking for.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disallow changing template's
index_modefield fromtime_seriesto something else,if a tsdb data stream still matches with that template.
Followup from #83843