[Test] Fix header value assertion for 401 error #83037
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The WWW-Authenticate header is multi-valued. In rare cases, the first value may not be the one beginning with "Basic". The PR makes the assertion agnostic to the order and also asserts for all possible header values. Resolves: elastic#83022
ywangd
added
>test
|
Pinging @elastic/es-security (Team:Security) |
ywangd
added a commit
to ywangd/elasticsearch
that referenced
this pull request
Feb 1, 2022
The WWW-Authenticate header is multi-valued. In rare cases, the first value may not be the one beginning with "Basic". The PR makes the assertion agnostic to the order and also asserts for all possible header values. Resolves: elastic#83022
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 1, 2022
* Fix test in AnonymousUserIntegTests #82977 All test cluster nodes should be using the same value for setting ANONYMOUS_AUTHORIZATION_EXCEPTION_SETTING. * [Test] Fix header value assertion for 401 error (#83037) The WWW-Authenticate header is multi-valued. In rare cases, the first value may not be the one beginning with "Basic". The PR makes the assertion agnostic to the order and also asserts for all possible header values. Resolves: #83022 Co-authored-by: Albert Zaharovits <albert.zaharovits@elastic.co> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The WWW-Authenticate header is multi-valued. In rare cases, the first
value may not be the one beginning with "Basic". The PR makes the
assertion agnostic to the order and also asserts for all possible header
values.
Resolves: #83022