Skip to content

System index deprecation warning is not critical #79633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

williamrandolph
Copy link
Contributor

When we planned to fully cut off access to system indices in 8.0, we needed our system index deprecation warning to be critical. Now that we are merely hiding system indices, avoiding system index access is no longer critical, and there is very little that users can do to change their access patterns. Therefore, we should log the warning at WARN level, rather than at CRITICAL.

@williamrandolph williamrandolph added :Core/Infra/Core Core issues without another label >non-issue labels Oct 21, 2021
@elasticmachine elasticmachine added the Team:Core/Infra Meta label for core/infra team label Oct 21, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

Copy link
Contributor

@cjcenizal cjcenizal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making this change, Will! I think this is an improvement. At the same time, these logs will still show up in Upgrade Assistant due to Kibana accessing these system indices. Elasticsearch will complain to the user about something that Kibana is doing. It makes it look like our products don't play well together. What kind of impression will that leave with our users?

Also, as you pointed out, these logs aren't actionable -- so what's the point? They become noise in the upgrade process. Can we remove them entirely in 7.16?

Copy link
Contributor

@gwbrown gwbrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes LGTM, pending a decision on the points CJ raised.

@williamrandolph
Copy link
Contributor Author

Also, as you pointed out, these logs aren't actionable -- so what's the point? They become noise in the upgrade process. Can we remove them entirely in 7.16?

@cjcenizal Was this question something we needed to discuss before merging, or do we have other issues covering this point of discussion?

@cjcenizal
Copy link
Contributor

@williamrandolph No not a a blocker. @sebelga is now looking into this problem from the Kibana/UA side and will re-raise this concern in another context if necessary. Thanks for asking!

@williamrandolph williamrandolph merged commit 3cb7b03 into elastic:master Nov 4, 2021
williamrandolph added a commit to williamrandolph/elasticsearch that referenced this pull request Nov 4, 2021
When we planned to fully cut off access to system
indices in 8.0, we needed our system index deprecation
warning to be critical. Now that we are merely hiding
system indices, avoiding system index access is no
longer critical, and there is very little that users can
do to change their access patterns. Therefore, we
should log the warning at WARN level, rather than at
CRITICAL.
williamrandolph added a commit to williamrandolph/elasticsearch that referenced this pull request Nov 4, 2021
When we planned to fully cut off access to system
indices in 8.0, we needed our system index deprecation
warning to be critical. Now that we are merely hiding
system indices, avoiding system index access is no
longer critical, and there is very little that users can
do to change their access patterns. Therefore, we
should log the warning at WARN level, rather than at
CRITICAL.
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
8.0
7.16

elasticsearchmachine pushed a commit that referenced this pull request Nov 4, 2021
* System index deprecation warning is not critical (#79633)

When we planned to fully cut off access to system
indices in 8.0, we needed our system index deprecation
warning to be critical. Now that we are merely hiding
system indices, avoiding system index access is no
longer critical, and there is very little that users can
do to change their access patterns. Therefore, we
should log the warning at WARN level, rather than at
CRITICAL.

* Restore production code changes
elasticsearchmachine pushed a commit that referenced this pull request Nov 4, 2021
)

* System index deprecation warning is not critical (#79633)

When we planned to fully cut off access to system
indices in 8.0, we needed our system index deprecation
warning to be critical. Now that we are merely hiding
system indices, avoiding system index access is no
longer critical, and there is very little that users can
do to change their access patterns. Therefore, we
should log the warning at WARN level, rather than at
CRITICAL.

* Restore production code changes
@williamrandolph williamrandolph deleted the si/access-warning-not-critical branch May 23, 2022 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>bug :Core/Infra/Core Core issues without another label >non-issue Team:Core/Infra Meta label for core/infra team v7.16.0 v8.0.0-rc1 v8.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants