[7.x] Add other time accounting in HotThreads(#79392) #79507
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@elasticmachine update branch |
|
@elasticmachine update branch |
|
@elasticmachine update branch |
grcevski
pushed a commit
to grcevski/elasticsearch
that referenced
this pull request
Oct 20, 2021
The sort by change has been merged in 7.x now and therefore we should make 8.0 use the same BWC version. Relates to elastic#79392 and elastic#79507
grcevski
added a commit
that referenced
this pull request
Oct 25, 2021
grcevski
added a commit
to grcevski/elasticsearch
that referenced
this pull request
Oct 26, 2021
The sort by change has been merged in 7.x now and therefore we should make 8.0 use the same BWC version. Relates to elastic#79392 and elastic#79507 Co-authored-by: Nhat Nguyen <nhat.nguyen@elastic.co>
lockewritesdocs
pushed a commit
to lockewritesdocs/elasticsearch
that referenced
this pull request
Oct 28, 2021
The sort by change has been merged in 7.x now and therefore we should make 8.0 use the same BWC version. Relates to elastic#79392 and elastic#79507 Co-authored-by: Nhat Nguyen <nhat.nguyen@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the concept of 'other' time in the HotThreads report. This 'other' time is calculated as the 'unknown' time the Java threads spend running, while they are not in a WAIT/BLOCKED state and are not using the CPU directly. Typically this 'other' time ends up being consumed by I/O or by the JVM itself, e.g. GC.
We are making the HotThreads CPU report sort by default by the 'Total' runnable time, which equals the CPU time + the 'Other' time. The original sort CPU report sort order can still be invoked through the REST API, by specifying &sort=cpu in the _nodes/hot_threads API url parameters. For example: _nodes/hot_threads?type=cpu&threads=1000000&sort=cpu.
Backport of #79392