Expose ImmutableOpenMap.values as a Java Collection #78529
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arteam
force-pushed
the
expose-open-hash-map-value-as-collection
branch
from
d77d7a2 to
16e6a77
Compare
|
@elasticmachine run elasticsearch-ci/rest-compatibility |
arteam
force-pushed
the
expose-open-hash-map-value-as-collection
branch
from
16e6a77 to
794a037
Compare
|
@elasticmachine update branch |
…p-value-as-collection
|
@elasticmachine run elasticsearch-ci/part-2 |
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
rjernst
reviewed
Oct 4, 2021
There was a problem hiding this comment.
The change overall looks good, and I like the direction this is taking us, removing direct use of hppc cursors. I think we can make the tests more robust, in general using hamcrest marchers for collection containment to give better error messages and avoid order differences across systems.
server/src/test/java/org/elasticsearch/common/collect/ImmutableOpenMapTests.java
Outdated
Show resolved
Hide resolved
server/src/test/java/org/elasticsearch/common/collect/ImmutableOpenMapTests.java
Outdated
Show resolved
Hide resolved
server/src/test/java/org/elasticsearch/common/collect/ImmutableOpenMapTests.java
Outdated
Show resolved
Hide resolved
|
@elasticmachine update branch |
henningandersen
approved these changes
Oct 4, 2021
server/src/main/java/org/elasticsearch/cluster/metadata/IndexMetadata.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/cluster/metadata/IndexMetadata.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/cluster/metadata/IndexMetadata.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/cluster/metadata/Metadata.java
Outdated
Show resolved
Hide resolved
server/src/test/java/org/elasticsearch/cluster/ClusterChangedEventTests.java
Outdated
Show resolved
Hide resolved
x-pack/plugin/ql/src/main/java/org/elasticsearch/xpack/ql/index/IndexResolver.java
Outdated
Show resolved
Hide resolved
.../src/main/java/org/elasticsearch/repositories/blobstore/testkit/RepositoryAnalyzeAction.java
Outdated
Show resolved
Hide resolved
…p-value-as-collection
|
@elasticmachine update branch |
arteam
added
auto-backport
|
Thanks Ryan and Henning! |
💔 Backport failed
You can use sqren/backport to manually backport by running |
arteam
added a commit
to arteam/elasticsearch
that referenced
this pull request
Oct 5, 2021
elastic#76921 added support for getting entries as a Java stream, elastic#77897 added the ability to get keys as a Set. This PR adds the values method which returns a Collection to bring the ImmutableOpenMap API closer to java.util.Map (cherry picked from commit cb73e3f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#76921 added support for getting
entriesas a Java stream, #77897 added the ability to get keys as aSet. This PR adds thevaluesmethod which returns aCollectionto bring theImmutableOpenMapAPI closer tojava.util.Map