Add support for getting a key set for ImmutableOpenMap #77897
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arteam
force-pushed
the
add-support-for-keys-stream-on-immutable-open-map
branch
2 times, most recently
from
f41f21b to
9d17328
Compare
Currently, we support only getting an iterator which is quite cumbersome to work with. The Streams API interacts much better with Java Collections.
arteam
force-pushed
the
add-support-for-keys-stream-on-immutable-open-map
branch
from
9d17328 to
25c1b9e
Compare
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
arteam
added
the
:Distributed Indexing/Distributed
elasticmachine
added
the
Team:Distributed (Obsolete)
|
Pinging @elastic/es-distributed (Team:Distributed) |
|
@elasticmachine update branch |
rjernst
reviewed
Sep 23, 2021
server/src/main/java/org/elasticsearch/common/collect/ImmutableOpenMap.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/common/collect/ImmutableOpenMap.java
Outdated
Show resolved
Hide resolved
x-pack/plugin/ccr/src/main/java/org/elasticsearch/xpack/ccr/repository/CcrRepository.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/cluster/metadata/Metadata.java
Outdated
Show resolved
Hide resolved
.../src/test/java/org/elasticsearch/action/admin/indices/alias/get/GetAliasesResponseTests.java
Outdated
Show resolved
Hide resolved
server/src/test/java/org/elasticsearch/cluster/node/DiscoveryNodesTests.java
Outdated
Show resolved
Hide resolved
arteam
requested review from
henningandersen and
rjernst
and removed request for
henningandersen
…ng(allAliases::add)" This reverts commit 9066ef6.
rjernst
requested changes
Sep 27, 2021
server/src/main/java/org/elasticsearch/common/collect/ImmutableOpenMap.java
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/common/collect/ImmutableOpenMap.java
Outdated
Show resolved
Hide resolved
It returns ints
server/src/main/java/org/elasticsearch/common/collect/ImmutableOpenMap.java
Show resolved
Hide resolved
arteam
added
the
auto-backport
arteam
changed the title
arteam
deleted the
add-support-for-keys-stream-on-immutable-open-map
branch
|
Thank you both! |
💔 Backport failed
You can use sqren/backport to manually backport by running |
arteam
added a commit
to arteam/elasticsearch
that referenced
this pull request
Sep 29, 2021
arteam
added a commit
that referenced
this pull request
Sep 30, 2021
arteam
added a commit
that referenced
this pull request
Oct 5, 2021
arteam
added a commit
to arteam/elasticsearch
that referenced
this pull request
Oct 5, 2021
elastic#76921 added support for getting entries as a Java stream, elastic#77897 added the ability to get keys as a Set. This PR adds the values method which returns a Collection to bring the ImmutableOpenMap API closer to java.util.Map (cherry picked from commit cb73e3f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we support only getting an iterator which is quite cumbersome to work with. Working with a set view is much better, because it bridges the iterator with
Set.#76921 added support for getting a stream on a map's values, we can provide a similar facility for keys and simplify a lot of client code that process the map's keys in an iterative way.