[Transform] Simplify code for destination index mappings deduction #68970
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Pinging @elastic/ml-core (Team:ML) |
przemekwitek
force-pushed
the
transform_use_runtime_fields_in_field_caps
branch
2 times, most recently
from
01f88f8 to
be4f871
Compare
Contributor
Author
|
run elasticsearch-ci/2 |
przemekwitek
force-pushed
the
transform_use_runtime_fields_in_field_caps
branch
from
be4f871 to
cb4bf75
Compare
przemekwitek
added a commit
to przemekwitek/elasticsearch
that referenced
this pull request
Feb 16, 2021
przemekwitek
added a commit
that referenced
this pull request
Feb 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR takes advantage of #68904 by simplifying how the destination index mappings are being deduced.
Instead of merging the
FieldCapabilitiesResponsewith runtime mappings in Transform code, the new field ofFieldCapabilitiesRequestis used.Labeling this as
>non-issueas this PR alters an unreleased feature (i.e. search runtime fields).Closes #68516