-
Notifications
You must be signed in to change notification settings - Fork 25.3k
Speed up rounding in auto_date_histogram #56384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This wires `auto_date_histogram` into the rounding optimization that I built in elastic#55559. This is should significantly speed up any `auto_date_histogram`s with `time_zone`s on them.
Pinging @elastic/es-analytics-geo (:Analytics/Aggregations) |
I'm not actually sure how to make a proper unit test that this is "plugged in". I will add some benchmark results with it eventually though. My desktop is currently busy benchmarking #56371. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I've finally finished the benchmarks. When there is a time zone and the index contains a daylight savings time transition this cuts the runtime of
Note: The "after" numbers for |
Actually both of them aren't quite right. But they can give you a sense that this particular |
This wires `auto_date_histogram` into the rounding optimization that I built in elastic#55559. This is should significantly speed up any `auto_date_histogram`s with `time_zone`s on them.
This wires
auto_date_histogram
into the rounding optimization that Ibuilt in #55559. This is should significantly speed up any
auto_date_histogram
s withtime_zone
s on them.