Switch role pluggability to use SPI #54370
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit switches discovery node role pluggability to use SPI. This eliminates an ugly public static method on DiscoveryNode. Instead of pulling roles out of plugins and pushing them into discovery node, discovery node now pulls them directly out of plugins.
jasontedor
added
>enhancement
:Core/Infra/Plugins
|
Pinging @elastic/es-core-infra (:Core/Infra/Plugins) |
jasontedor
commented
Mar 28, 2020
...e-extension/src/test/resources/rest-api-spec/test/discovery_node_role_extension/10_basic.yml
Show resolved
Hide resolved
|
This presents some serious challenges in internal cluster tests in X-Pack that require additional roles be available for the test. This means that we have to do SPI for classpath plugins, and then clean them up after the test, which means we haven't really solved any problems here, just moved them. Therefore, I am closing this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit switches discovery node role pluggability to use SPI. This eliminates an ugly public static method on DiscoveryNode. Instead of pulling roles out of plugins and pushing them into discovery node, discovery node now pulls them directly out of plugins.