[Transform] fixing naming in HLRC and _cat to match API content #54300
Conversation
|
Pinging @elastic/ml-core (:ml/Transform) |
benwtrent
force-pushed
the
feature/transform-unify-stats-naming
branch
from
211c6af to
19e5486
Compare
|
@elasticmachine update branch |
|
FYI @lcawl |
| static ParseField TRIGGER_COUNT = new ParseField("trigger_count"); | ||
| static ParseField INDEX_TIME_IN_MS = new ParseField("index_time_in_ms"); | ||
| static ParseField SEARCH_TIME_IN_MS = new ParseField("search_time_in_ms"); | ||
| static ParseField PROCESSING_TIME_IN_MS = new ParseField("processing_time_in_ms"); |
There was a problem hiding this comment.
processing_time_in_ms
Does this mean we need to add this property to the stats object in https://www.elastic.co/guide/en/elasticsearch/reference/master/get-transform-stats.html ?
There was a problem hiding this comment.
Sorry, that's my fault. In #53770 I added processing_time_in_ms and processing_total.
The 2 are counterparts of the search and index one:
The amount of time processing results, in milliseconds.
The number of processing operations.
This is basically what happens between search and index and shows the time/load the transform task itself used.
There was a problem hiding this comment.
Thanks, I've created #54368 to add those.
| static ParseField PROCESSING_TIME_IN_MS = new ParseField("processing_time_in_ms"); | ||
| static ParseField INDEX_TOTAL = new ParseField("index_total"); | ||
| static ParseField SEARCH_TOTAL = new ParseField("search_total"); | ||
| static ParseField PROCESSING_TOTAL = new ParseField("processing_total"); |
There was a problem hiding this comment.
processing_total
This also doesn't appear in https://www.elastic.co/guide/en/elasticsearch/reference/master/get-transform-stats.html
Should it?
There was a problem hiding this comment.
i think it should be in stats. I am not 100% sure it should be in the _cat API though. Right now processing times are so small that they are pretty insignificant.
There was a problem hiding this comment.
Likewise this will be fixed in #54368
|
@elasticmachine update branch |
There was a problem hiding this comment.
Documentation LGTM
Preview: http://elasticsearch_54300.docs-preview.app.elstc.co/guide/en/elasticsearch/reference/master/cat-transforms.html
…tic#54300) Fixing the naming of the HLRC values to match the ToXContent field names (i.e. the field names returned from an API call). Also fixes the names in the _cat API as well. closes elastic#53946
…tic#54300) Fixing the naming of the HLRC values to match the ToXContent field names (i.e. the field names returned from an API call). Also fixes the names in the _cat API as well. closes elastic#53946
Fixing the naming of the HLRC values to match the ToXContent field names (i.e. the field names returned from an API call).
Also fixes the names in the _cat API as well.
closes #53946