Allow keystore add-file to handle multiple settings #54240
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasontedor
added
>enhancement
:Core/Infra/Settings
|
Pinging @elastic/es-core-infra (:Core/Infra/Settings) |
Today the keystore add-file command can only handle adding a single setting/file pair in a single invocation. This incurs the startup costs of the JVM many times, which in some environments can be expensive. This commit teaches the add-file keystore command to accept adding multiple settings in a single invocation.
jasontedor
force-pushed
the
keystore-add-multiple-file-settings
branch
from
617dfda to
d9bf373
Compare
jasontedor
changed the title
rjernst
reviewed
Mar 26, 2020
| if (argumentValues.size() == 0) { | ||
| throw new UserException(ExitCodes.USAGE, "Missing setting name"); | ||
| } | ||
| String setting = argumentValues.get(0); | ||
| if (argumentValues.size() % 2 != 0) { |
There was a problem hiding this comment.
Don't we need to also ensure size > 1? Otherwise I think we silently ignore giving the add-file command with no arguments?
There was a problem hiding this comment.
That's handled on the previous if? If size < 1 then it must be == 0 and we bail?
There was a problem hiding this comment.
The if currently on line 58 of this diff.
There was a problem hiding this comment.
I can't believe I missed that. :shame:
jasontedor
added a commit
that referenced
this pull request
Mar 26, 2020
Today the keystore add-file command can only handle adding a single setting/file pair in a single invocation. This incurs the startup costs of the JVM many times, which in some environments can be expensive. This commit teaches the add-file keystore command to accept adding multiple settings in a single invocation.
jasontedor
added a commit
that referenced
this pull request
Mar 26, 2020
Today the keystore add-file command can only handle adding a single setting/file pair in a single invocation. This incurs the startup costs of the JVM many times, which in some environments can be expensive. This commit teaches the add-file keystore command to accept adding multiple settings in a single invocation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today the keystore add-file command can only handle adding a single setting/file pair in a single invocation. This incurs the startup costs of the JVM many times, which in some environments can be expensive. This commit teaches the add-file keystore command to accept adding multiple settings in a single invocation.
Relates #54191