[ML] adjusting feature importance mapping for multi-class support #53821
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/ml-core (:ml) |
...k/plugin/core/src/main/java/org/elasticsearch/xpack/core/ml/dataframe/analyses/MapUtils.java
Show resolved
Hide resolved
...re/src/test/java/org/elasticsearch/xpack/core/ml/dataframe/analyses/ClassificationTests.java
Show resolved
Hide resolved
...re/src/test/java/org/elasticsearch/xpack/core/ml/dataframe/analyses/ClassificationTests.java
Show resolved
Hide resolved
...tive-multi-node-tests/src/test/java/org/elasticsearch/xpack/ml/integration/RegressionIT.java
Outdated
Show resolved
Hide resolved
...tive-multi-node-tests/src/test/java/org/elasticsearch/xpack/ml/integration/RegressionIT.java
Outdated
Show resolved
Hide resolved
...-multi-node-tests/src/test/java/org/elasticsearch/xpack/ml/integration/ClassificationIT.java
Outdated
Show resolved
Hide resolved
…is-adjust-feature-importance-format
|
run elasticsearch-ci/2 |
1 similar comment
|
run elasticsearch-ci/2 |
benwtrent
deleted the
feature/ml-analysis-adjust-feature-importance-format
branch
benwtrent
added a commit
to benwtrent/elasticsearch
that referenced
this pull request
Mar 23, 2020
…astic#53821) Feature importance storage format is changing to encompass multi-class. Feature importance objects are now mapped as follows (logistic) Regression: ``` { "feature_name": "feature_0", "importance": -1.3 } ``` Multi-class [class names are `foo`, `bar`, `baz`] ``` { “feature_name”: “feature_0”, “importance”: 2.0, // sum(abs()) of class importances “foo”: 1.0, “bar”: 0.5, “baz”: -0.5 }, ``` This change adjusts the mapping creation for analytics so that the field is mapped as a `nested` type. Native side change: elastic/ml-cpp#1071
benwtrent
added a commit
that referenced
this pull request
Mar 23, 2020
…3821) (#54013) Feature importance storage format is changing to encompass multi-class. Feature importance objects are now mapped as follows (logistic) Regression: ``` { "feature_name": "feature_0", "importance": -1.3 } ``` Multi-class [class names are `foo`, `bar`, `baz`] ``` { “feature_name”: “feature_0”, “importance”: 2.0, // sum(abs()) of class importances “foo”: 1.0, “bar”: 0.5, “baz”: -0.5 }, ``` This change adjusts the mapping creation for analytics so that the field is mapped as a `nested` type. Native side change: elastic/ml-cpp#1071
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature importance storage format is changing to encompass multi-class.
Feature importance objects are now mapped as follows
(logistic) Regression:
Multi-class [class names are
foo,bar,baz]This change adjusts the mapping creation for analytics so that the field is mapped as a
nestedtype.Native side change: elastic/ml-cpp#1071