Skip to content

Remove [removal-of-types] docs page, and point to 7x docs #53670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 18, 2020

Conversation

romseygeek
Copy link
Contributor

Given that types have been removed entirely in 8.0, we don't need a detailed page
explaining what they are and why they are going away. This commit replaces the
page with a short paragraph saying that types are no longer supported, and a link
to the [removal-of-types] page in 7x

@romseygeek romseygeek added >docs General docs changes :Search Foundations/Mapping Index mappings, including merging and defining field types v8.0.0 labels Mar 17, 2020
@romseygeek romseygeek self-assigned this Mar 17, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs (>docs)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search (:Search/Mapping)

Copy link
Contributor

@colings86 colings86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I will defer to @jrodewig for final review

versions of queries that perform document lookups, such as `terms`.
Elasticsearch 8.0.0 no longer supports mapping types. For details on how to
migrate your clusters away from mapping types, see the
{ref-7x}/removal-of-types.html[removal of types] documentation for the 7x release
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{ref-7x}/removal-of-types.html[removal of types] documentation for the 7x release
{ref-7x}/removal-of-types.html[removal of types] documentation for the 7.x release.

Copy link
Contributor

@jrodewig jrodewig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor nit. Otherwise LGTM.

@romseygeek romseygeek merged commit 534a4a9 into elastic:master Mar 18, 2020
@jpountz jpountz mentioned this pull request Mar 18, 2020
66 tasks
@pgomulka pgomulka mentioned this pull request Mar 25, 2020
66 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>docs General docs changes :Search Foundations/Mapping Index mappings, including merging and defining field types v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants